components/sessions/core/in_memory_tab_restore_service.cc - Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sessions/core/in_memory_tab_restore_service.cc

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup

Patch Set: Get session ID from entries, take tabs' active status directly instead of an index Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sessions/core/in_memory_tab_restore_service.h ('k') | components/sessions/core/persistent_tab_restore_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sessions/core/in_memory_tab_restore_service.cc

diff --git a/components/sessions/core/in_memory_tab_restore_service.cc b/components/sessions/core/in_memory_tab_restore_service.cc

index 5caf5767c3de93b8a049084169a0720308d0c533..902d008bac8b7f02307614c3bc64e242c714f9dd 100644

--- a/components/sessions/core/in_memory_tab_restore_service.cc

+++ b/components/sessions/core/in_memory_tab_restore_service.cc

@@ -55,8 +55,8 @@ std::vector<LiveTab*> InMemoryTabRestoreService::RestoreMostRecentEntry(

return helper_.RestoreMostRecentEntry(context);

}

-TabRestoreService::Tab* InMemoryTabRestoreService::RemoveTabEntryById(

- SessionID::id_type id) {

+std::unique_ptr<TabRestoreService::Tab>

+InMemoryTabRestoreService::RemoveTabEntryById(SessionID::id_type id) {

return helper_.RemoveTabEntryById(id);

}