Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2700)

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.h

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup
Patch Set: Get session ID from entries, take tabs' active status directly instead of an index Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/sessions/sessions_api.h
diff --git a/chrome/browser/extensions/api/sessions/sessions_api.h b/chrome/browser/extensions/api/sessions/sessions_api.h
index cd1afeb4eef339ba6a5ddbb594d8a61cc618cbbc..6bdc9dd4dcb993a5016596e9278e927a066d8df3 100644
--- a/chrome/browser/extensions/api/sessions/sessions_api.h
+++ b/chrome/browser/extensions/api/sessions/sessions_api.h
@@ -36,13 +36,11 @@ class SessionsGetRecentlyClosedFunction : public ChromeSyncExtensionFunction {
private:
api::tabs::Tab CreateTabModel(const sessions::TabRestoreService::Tab& tab,
- int session_id,
- int selected_index);
+ bool active);
std::unique_ptr<api::windows::Window> CreateWindowModel(
- const sessions::TabRestoreService::Window& window,
- int session_id);
+ const sessions::TabRestoreService::Window& window);
std::unique_ptr<api::sessions::Session> CreateSessionModel(
- const sessions::TabRestoreService::Entry* entry);
+ const sessions::TabRestoreService::Entry& entry);
};
class SessionsGetDevicesFunction : public ChromeSyncExtensionFunction {
@@ -55,7 +53,7 @@ class SessionsGetDevicesFunction : public ChromeSyncExtensionFunction {
api::tabs::Tab CreateTabModel(const std::string& session_tag,
const sessions::SessionTab& tab,
int tab_index,
- int selected_index);
+ bool active);
std::unique_ptr<api::windows::Window> CreateWindowModel(
const sessions::SessionWindow& window,
const std::string& session_tag);
« no previous file with comments | « chrome/browser/android/recently_closed_tabs_bridge.cc ('k') | chrome/browser/extensions/api/sessions/sessions_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698