Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: components/sessions/core/in_memory_tab_restore_service.h

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup
Patch Set: Eliminate a use-after-free, Windows build fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/core/in_memory_tab_restore_service.h
diff --git a/components/sessions/core/in_memory_tab_restore_service.h b/components/sessions/core/in_memory_tab_restore_service.h
index eeb490448658eec66a9fffb60d73dc8e7fb2a0c0..784d6c664f0ca78e27e1b78cd7c7fe1e8d1b5ced 100644
--- a/components/sessions/core/in_memory_tab_restore_service.h
+++ b/components/sessions/core/in_memory_tab_restore_service.h
@@ -42,7 +42,7 @@ class SESSIONS_EXPORT InMemoryTabRestoreService : public TabRestoreService {
const Entries& entries() const override;
std::vector<LiveTab*> RestoreMostRecentEntry(
LiveTabContext* context) override;
- Tab* RemoveTabEntryById(SessionID::id_type id) override;
+ std::unique_ptr<Tab> RemoveTabEntryById(SessionID::id_type id) override;
std::vector<LiveTab*> RestoreEntryById(
LiveTabContext* context,
SessionID::id_type id,

Powered by Google App Engine
This is Rietveld 408576698