chrome/browser/win/jumplist.h - Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/win/jumplist.h

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup

Patch Set: Eliminate a use-after-free, Windows build fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm ('K') | « chrome/browser/ui/views/frame/global_menu_bar_x11.cc ('k') | chrome/browser/win/jumplist.cc » ('j') | components/sessions/core/persistent_tab_restore_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/win/jumplist.h

diff --git a/chrome/browser/win/jumplist.h b/chrome/browser/win/jumplist.h

index 24ca8a54823000b7103fd8ad9257bc91563007b3..738832c4aa54294c2217cf7c083272ea06875975 100644

--- a/chrome/browser/win/jumplist.h

+++ b/chrome/browser/win/jumplist.h

@@ -116,10 +116,10 @@ class JumpList : public sessions::TabRestoreServiceObserver,

// given list.

// These functions are copied from the RecentlyClosedTabsHandler class for

// compatibility with the new-tab page.

- bool AddTab(const sessions::TabRestoreService::Tab* tab,

+ bool AddTab(const sessions::TabRestoreService::Tab& tab,

ShellLinkItemList* list,

size_t max_items);

- void AddWindow(const sessions::TabRestoreService::Window* window,

+ void AddWindow(const sessions::TabRestoreService::Window& window,

ShellLinkItemList* list,

size_t max_items);