chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc - Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup

Patch Set: Eliminate a use-after-free, Windows build fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/sessions/sessions_api.cc ('K') | « chrome/browser/extensions/api/sessions/sessions_api.cc ('k') | chrome/browser/sessions/persistent_tab_restore_service_unittest.cc » ('j') | chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

diff --git a/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc b/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

index a196c7b409872fd37139b7cbc88682c293d95ab5..5c76b35509b13a041bd5744e7d3186a166257a0a 100644

--- a/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

+++ b/chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc

@@ -38,12 +38,11 @@ IN_PROC_BROWSER_TEST_F(PersistentTabRestoreServiceBrowserTest, RestoreApp) {

// One entry should be created.

ASSERT_EQ(1U, trs->entries().size());

const sessions::TabRestoreService::Entry* restored_entry =

- trs->entries().front();

+ trs->entries().front().get();

// It should be a window with an app.

ASSERT_EQ(sessions::TabRestoreService::WINDOW, restored_entry->type);

- const Window* restored_window =

- static_cast<const Window*>(restored_entry);

+ const Window* restored_window = static_cast<const Window*>(restored_entry);

EXPECT_EQ(app_name, restored_window->app_name);

}