chrome/browser/extensions/api/sessions/sessions_api.h - Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.h

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup

Patch Set: Eliminate a use-after-free, Windows build fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/recently_closed_tabs_bridge.cc ('k') | chrome/browser/extensions/api/sessions/sessions_api.cc » ('j') | chrome/browser/extensions/api/sessions/sessions_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/sessions_api.h

diff --git a/chrome/browser/extensions/api/sessions/sessions_api.h b/chrome/browser/extensions/api/sessions/sessions_api.h

index cd1afeb4eef339ba6a5ddbb594d8a61cc618cbbc..77c477d060a0367b31261d5f62da7dfac57f1d39 100644

--- a/chrome/browser/extensions/api/sessions/sessions_api.h

+++ b/chrome/browser/extensions/api/sessions/sessions_api.h

@@ -42,7 +42,7 @@ class SessionsGetRecentlyClosedFunction : public ChromeSyncExtensionFunction {

const sessions::TabRestoreService::Window& window,

int session_id);

std::unique_ptr<api::sessions::Session> CreateSessionModel(

- const sessions::TabRestoreService::Entry* entry);

+ const sessions::TabRestoreService::Entry& entry);

};

class SessionsGetDevicesFunction : public ChromeSyncExtensionFunction {