Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: components/sessions/core/in_memory_tab_restore_service.h

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup
Patch Set: Get session ID from entries, take tabs' active status directly instead of an index Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SESSIONS_CORE_IN_MEMORY_TAB_RESTORE_SERVICE_H_ 5 #ifndef COMPONENTS_SESSIONS_CORE_IN_MEMORY_TAB_RESTORE_SERVICE_H_
6 #define COMPONENTS_SESSIONS_CORE_IN_MEMORY_TAB_RESTORE_SERVICE_H_ 6 #define COMPONENTS_SESSIONS_CORE_IN_MEMORY_TAB_RESTORE_SERVICE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 24 matching lines...) Expand all
35 // TabRestoreService: 35 // TabRestoreService:
36 void AddObserver(TabRestoreServiceObserver* observer) override; 36 void AddObserver(TabRestoreServiceObserver* observer) override;
37 void RemoveObserver(TabRestoreServiceObserver* observer) override; 37 void RemoveObserver(TabRestoreServiceObserver* observer) override;
38 void CreateHistoricalTab(LiveTab* live_tab, int index) override; 38 void CreateHistoricalTab(LiveTab* live_tab, int index) override;
39 void BrowserClosing(LiveTabContext* context) override; 39 void BrowserClosing(LiveTabContext* context) override;
40 void BrowserClosed(LiveTabContext* context) override; 40 void BrowserClosed(LiveTabContext* context) override;
41 void ClearEntries() override; 41 void ClearEntries() override;
42 const Entries& entries() const override; 42 const Entries& entries() const override;
43 std::vector<LiveTab*> RestoreMostRecentEntry( 43 std::vector<LiveTab*> RestoreMostRecentEntry(
44 LiveTabContext* context) override; 44 LiveTabContext* context) override;
45 Tab* RemoveTabEntryById(SessionID::id_type id) override; 45 std::unique_ptr<Tab> RemoveTabEntryById(SessionID::id_type id) override;
46 std::vector<LiveTab*> RestoreEntryById( 46 std::vector<LiveTab*> RestoreEntryById(
47 LiveTabContext* context, 47 LiveTabContext* context,
48 SessionID::id_type id, 48 SessionID::id_type id,
49 WindowOpenDisposition disposition) override; 49 WindowOpenDisposition disposition) override;
50 void LoadTabsFromLastSession() override; 50 void LoadTabsFromLastSession() override;
51 bool IsLoaded() const override; 51 bool IsLoaded() const override;
52 void DeleteLastSession() override; 52 void DeleteLastSession() override;
53 void Shutdown() override; 53 void Shutdown() override;
54 54
55 private: 55 private:
56 std::unique_ptr<TabRestoreServiceClient> client_; 56 std::unique_ptr<TabRestoreServiceClient> client_;
57 TabRestoreServiceHelper helper_; 57 TabRestoreServiceHelper helper_;
58 58
59 DISALLOW_COPY_AND_ASSIGN(InMemoryTabRestoreService); 59 DISALLOW_COPY_AND_ASSIGN(InMemoryTabRestoreService);
60 }; 60 };
61 61
62 } // namespace sessions 62 } // namespace sessions
63 63
64 #endif // COMPONENTS_SESSIONS_CORE_IN_MEMORY_TAB_RESTORE_SERVICE_H_ 64 #endif // COMPONENTS_SESSIONS_CORE_IN_MEMORY_TAB_RESTORE_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698