components/sessions/content/content_platform_specific_tab_data.h - Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sessions/content/content_platform_specific_tab_data.h

Issue 2200993004: Make TabRestoreService::Entry noncopyable and fix up surrounding code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-test-cleanup

Patch Set: Get session ID from entries, take tabs' active status directly instead of an index Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_SESSIONS_CONTENT_CONTENT_PLATFORM_SPECIFIC_TAB_DATA_H_	5 #ifndef COMPONENTS_SESSIONS_CONTENT_CONTENT_PLATFORM_SPECIFIC_TAB_DATA_H_

6 #define COMPONENTS_SESSIONS_CONTENT_CONTENT_PLATFORM_SPECIFIC_TAB_DATA_H_	6 #define COMPONENTS_SESSIONS_CONTENT_CONTENT_PLATFORM_SPECIFIC_TAB_DATA_H_

7	7

8 #include "base/memory/ref_counted.h"	8 #include "base/memory/ref_counted.h"

9 #include "components/sessions/core/live_tab.h"	9 #include "components/sessions/core/live_tab.h"

10 #include "components/sessions/core/sessions_export.h"	10 #include "components/sessions/core/sessions_export.h"

(...skipping 14 matching lines...) Expand all Loading...
25 public:	25 public:

26 explicit ContentPlatformSpecificTabData(content::WebContents* web_contents);	26 explicit ContentPlatformSpecificTabData(content::WebContents* web_contents);

27 ContentPlatformSpecificTabData();	27 ContentPlatformSpecificTabData();

28 ~ContentPlatformSpecificTabData() override;	28 ~ContentPlatformSpecificTabData() override;

29	29

30 content::SessionStorageNamespace* session_storage_namespace() const {	30 content::SessionStorageNamespace* session_storage_namespace() const {

31 return session_storage_namespace_.get();	31 return session_storage_namespace_.get();

32 }	32 }

33	33

34 private:	34 private:

35 // PlatformSpecificTabData:

36 std::unique_ptr<PlatformSpecificTabData> Clone() override;

37

38 scoped_refptr<content::SessionStorageNamespace> session_storage_namespace_;	35 scoped_refptr<content::SessionStorageNamespace> session_storage_namespace_;

39 };	36 };

40	37

41 } // namespace sessions	38 } // namespace sessions

42	39

43 #endif // COMPONENTS_SESSIONS_CONTENT_CONTENT_PLATFORM_SPECIFIC_TAB_DATA_H_	40 #endif // COMPONENTS_SESSIONS_CONTENT_CONTENT_PLATFORM_SPECIFIC_TAB_DATA_H_

OLD	NEW