ShelfLayoutManager virtual keyboard - do not change work area of screen if in non-sticky mode.

ShelfLayoutManager virtual keyboard - do not change work area of screen if in non-sticky mode.

This is dependent on https://codereview.chromium.org/2180603002/ which
introduces the kAshUseNewVKWindowBehavior switch.
Added a parameter to UpdateBoundsAndOpacity that signals whether or not
to change the work area of the screen. The switch enables this behavior.

BUG=633437
Committed: https://crrev.com/b3dbde950da912fb78154beff5ea827a6e8cf5dd
Cr-Commit-Position: refs/heads/master@{#411427}

[hariank, 2016-08-02 01:49:55]

Description was changed from

==========
ShelfLayoutManager virtual keyboard - do not change work area of screen if in
non-sticky mode.

This is dependent on https://codereview.chromium.org/2180603002/ which
introduces the kAshUseNewVKWindowBehavior switch.
Added a parameter to UpdateBoundsAndOpacity that signals whether or not
to change the work area of the screen. The switch enables this behavior.

BUG=633437
==========

to

==========
ShelfLayoutManager virtual keyboard - do not change work area of screen if in
non-sticky mode.

This is dependent on https://codereview.chromium.org/2180603002/ which
introduces the kAshUseNewVKWindowBehavior switch.
Added a parameter to UpdateBoundsAndOpacity that signals whether or not
to change the work area of the screen. The switch enables this behavior.

BUG=633437
==========

[hariank, 2016-08-02 01:49:55]

hariank@google.com changed reviewers:
+ oshima@chromium.org, skuhne@google.com

[oshima, 2016-08-02 16:33:53]

can you add a unit test for this too?

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.cc:569:
WillChangeVisibilityState(visibility_state()));
Instead of coyping, can you add change_work_area parameter to LayoutShelf, and
call it from here?

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.cc:771: // if keyboard is not shown.
can you test if this works in lock screen?

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.h:242: // any, are complete.
update the comment and explain how |change_work_area| works.

[hariank, 2016-08-03 18:09:40]

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.cc:569:
WillChangeVisibilityState(visibility_state()));
On 2016/08/02 16:33:53, oshima wrote:
> Instead of coyping, can you add change_work_area parameter to LayoutShelf, and
> call it from here?

Done.

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.cc:771: // if keyboard is not shown.
On 2016/08/02 16:33:53, oshima wrote:
> can you test if this works in lock screen?

Done.

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/2200963002/diff/1/ash/shelf/shelf_layout_mana...
ash/shelf/shelf_layout_manager.h:242: // any, are complete.
On 2016/08/02 16:33:53, oshima wrote:
> update the comment and explain how |change_work_area| works.

Done.

[oshima, 2016-08-03 21:22:38]

lgtm with nits

https://codereview.chromium.org/2200963002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2200963002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:692: UpdateBoundsAndOpacity(target_bounds,
true, true, delay_background_change
nit:
can you add the comment to bool value like

true /* animate */, true /* change_work_area */

same for other places.

https://codereview.chromium.org/2200963002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2200963002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager_unittest.cc:2048: 
nit:

   // test::AshTestBase:

[hariank, 2016-08-03 21:29:37]

https://codereview.chromium.org/2200963002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2200963002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:692: UpdateBoundsAndOpacity(target_bounds,
true, true, delay_background_change
On 2016/08/03 21:22:38, oshima wrote:
> nit:
> can you add the comment to bool value like
> 
> true /* animate */, true /* change_work_area */
> 
> same for other places.

Done.

https://codereview.chromium.org/2200963002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2200963002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager_unittest.cc:2048: 
On 2016/08/03 21:22:38, oshima wrote:
> nit:
> 
>    // test::AshTestBase:

Done.

[Mr4D (OOO till 08-26), 2016-08-11 18:44:15]

skuhne@chromium.org changed reviewers:
+ skuhne@chromium.org

[Mr4D (OOO till 08-26), 2016-08-11 18:44:15]

lgtm

[hariank, 2016-08-11 19:02:06]

hariank@google.com changed reviewers:
- skuhne@google.com

[hariank, 2016-08-11 20:37:17]

The CQ bit was checked by hariank@google.com

[hariank, 2016-08-11 20:37:17]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2200963002/#ps40001
(title: "ShelfLayoutManager virtual keyboard - do not change work area of screen
if in non-sticky mode.")

[commit-bot: I haz the power, 2016-08-11 20:37:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 20:40:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 20:40:18]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[hariank, 2016-08-11 21:02:38]

The CQ bit was checked by hariank@google.com

[hariank, 2016-08-11 21:02:38]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2200963002/#ps60001
(title: "ShelfLayoutManager virtual keyboard - do not change work area of screen
if in non-sticky mode.")

[hariank, 2016-08-11 21:02:40]

The CQ bit was unchecked by hariank@google.com

[hariank, 2016-08-11 21:02:42]

The CQ bit was checked by hariank@google.com

[hariank, 2016-08-11 21:02:47]

The CQ bit was checked by hariank@google.com

[commit-bot: I haz the power, 2016-08-11 21:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 22:06:53]

Description was changed from

==========
ShelfLayoutManager virtual keyboard - do not change work area of screen if in
non-sticky mode.

This is dependent on https://codereview.chromium.org/2180603002/ which
introduces the kAshUseNewVKWindowBehavior switch.
Added a parameter to UpdateBoundsAndOpacity that signals whether or not
to change the work area of the screen. The switch enables this behavior.

BUG=633437
==========

to

==========
ShelfLayoutManager virtual keyboard - do not change work area of screen if in
non-sticky mode.

This is dependent on https://codereview.chromium.org/2180603002/ which
introduces the kAshUseNewVKWindowBehavior switch.
Added a parameter to UpdateBoundsAndOpacity that signals whether or not
to change the work area of the screen. The switch enables this behavior.

BUG=633437
==========

[commit-bot: I haz the power, 2016-08-11 22:06:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-11 22:09:00]

Description was changed from

==========
ShelfLayoutManager virtual keyboard - do not change work area of screen if in
non-sticky mode.

This is dependent on https://codereview.chromium.org/2180603002/ which
introduces the kAshUseNewVKWindowBehavior switch.
Added a parameter to UpdateBoundsAndOpacity that signals whether or not
to change the work area of the screen. The switch enables this behavior.

BUG=633437
==========

to

==========
ShelfLayoutManager virtual keyboard - do not change work area of screen if in
non-sticky mode.

This is dependent on https://codereview.chromium.org/2180603002/ which
introduces the kAshUseNewVKWindowBehavior switch.
Added a parameter to UpdateBoundsAndOpacity that signals whether or not
to change the work area of the screen. The switch enables this behavior.

BUG=633437

Committed: https://crrev.com/b3dbde950da912fb78154beff5ea827a6e8cf5dd
Cr-Commit-Position: refs/heads/master@{#411427}
==========

[commit-bot: I haz the power, 2016-08-11 22:09:01]

Patchset 4 (id:??) landed as
https://crrev.com/b3dbde950da912fb78154beff5ea827a6e8cf5dd
Cr-Commit-Position: refs/heads/master@{#411427}