Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2200913002: fixes #616, statics on callable functions (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #616, statics on callable functions also fixes `this` for them R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d7c240f3c3cdeca2868550bdf8113f312b7d9c88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -69 lines) Patch
M lib/runtime/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/compiler/code_generator.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M test/codegen/language/callable_test.dart View 2 chunks +24 lines, -2 lines 0 comments Download
M test/codegen_expected/corelib/apply3_test.js View 3 chunks +3 lines, -6 lines 0 comments Download
M test/codegen_expected/corelib/apply_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/call_argument_inference_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/call_function_apply_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/call_operator_test.js View 6 chunks +6 lines, -12 lines 0 comments Download
M test/codegen_expected/language/call_this_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/call_with_no_such_method_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/callable_test_none_multi.js View 3 chunks +50 lines, -8 lines 0 comments Download
M test/codegen_expected/language/cascade2_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/function_propagation_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/function_subtype3_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/function_subtype_call0_test.js View 3 chunks +3 lines, -6 lines 0 comments Download
M test/codegen_expected/language/function_subtype_call1_test.js View 2 chunks +2 lines, -4 lines 0 comments Download
M test/codegen_expected/language/function_subtype_call2_test.js View 2 chunks +2 lines, -4 lines 0 comments Download
M test/codegen_expected/language/regress_11010_test.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/codegen_expected/language/regress_21793_test_none_multi.js View 1 chunk +1 line, -2 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-02 00:09:47 UTC) #2
vsm
lgtm
4 years, 4 months ago (2016-08-02 00:12:27 UTC) #3
Jennifer Messerly
4 years, 4 months ago (2016-08-02 00:12:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d7c240f3c3cdeca2868550bdf8113f312b7d9c88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698