third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js - Issue 2200893003: DevTools: Add autocomplete for ARIA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Issue 2200893003: DevTools: Add autocomplete for ARIA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove done TODO Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/accessibility/ARIAMetadata.js ('K') | « third_party/WebKit/Source/devtools/front_end/accessibility/ARIAMetadata.js ('k') | third_party/WebKit/Source/devtools/front_end/accessibility/module.json » ('j') | third_party/WebKit/Source/devtools/scripts/aria_attributes.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

index d799945a5cb00e8a083b71e596d98f581ba0f995..cd80be00fa12244b1725e54004a570e47b786ed1 100644

--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

@@ -46,8 +46,9 @@ WebInspector.AccessibilitySidebarView.prototype = {

this._axNodeSubPane.setAXNode(accessibilityNode);

}

var node = this.node();

+ this._ariaSubPane.setNode(node);

lushnikov 2016/08/23 17:23:51 why this change?

aboxhall 2016/08/23 21:06:17 Fixes a bug where the ARIA sub-pane would get out

return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNode(node.id)

- .then(accessibilityNodeCallback.bind(this))

+ .then(accessibilityNodeCallback.bind(this));

/**