mash: Partially migrate ash/desktop_background to ash common types.

mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG=629605
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362
Cr-Commit-Position: refs/heads/master@{#409360}

[msw, 2016-08-02 03:43:44]

Description was changed from

==========
mash: Partially migrate ash/desktop_background to ash common.

BUG=629605
==========

to

==========
mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG=629605
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
==========

[msw, 2016-08-02 03:43:45]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-08-02 03:44:32]

Hey James, please take a look; thanks!

[msw, 2016-08-02 03:44:41]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 03:44:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 04:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 04:08:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-08-02 16:51:51]

LGTM with nits, assuming the bot failures are something simple.

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
File ash/desktop_background/desktop_background_controller.cc (left):

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:37: using
wallpaper::WallpaperResizer;
totally optional: using declarations don't bother me if you want to keep them.

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
File ash/desktop_background/desktop_background_controller.cc (right):

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:28: // How long to wait
reloading the wallpaper after the max display has changed.
nit: What the heck does "after the max display has changed" mean? :-) Maximum
display size?

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:95:
current_wallpaper_.reset(nullptr);
optional nit: or just reset()

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:216: for (auto
root_window_controller : Shell::GetAllRootWindowControllers()) {
nit: auto* or spell out the type

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:251:
current_wallpaper_.reset(nullptr);
optional nit: reset()

[msw, 2016-08-02 18:28:57]

The test fix was a simple one in GetMaxDisplaySizeInNative.

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
File ash/desktop_background/desktop_background_controller.cc (left):

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:37: using
wallpaper::WallpaperResizer;
On 2016/08/02 16:51:50, James Cook wrote:
> totally optional: using declarations don't bother me if you want to keep them.

I only like them when they cleanup a large part of the file.

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
File ash/desktop_background/desktop_background_controller.cc (right):

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:28: // How long to wait
reloading the wallpaper after the max display has changed.
On 2016/08/02 16:51:50, James Cook wrote:
> nit: What the heck does "after the max display has changed" mean? :-) Maximum
> display size?

Done. Simplified the comment.

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:95:
current_wallpaper_.reset(nullptr);
On 2016/08/02 16:51:50, James Cook wrote:
> optional nit: or just reset()

Done.

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:216: for (auto
root_window_controller : Shell::GetAllRootWindowControllers()) {
On 2016/08/02 16:51:50, James Cook wrote:
> nit: auto* or spell out the type

Done.

https://codereview.chromium.org/2200893002/diff/40001/ash/desktop_background/...
ash/desktop_background/desktop_background_controller.cc:251:
current_wallpaper_.reset(nullptr);
On 2016/08/02 16:51:50, James Cook wrote:
> optional nit: reset()

Done.

[msw, 2016-08-02 18:29:06]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-02 18:29:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2200893002/#ps60001
(title: "Address comments; fix test.")

[commit-bot: I haz the power, 2016-08-02 18:29:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-08-02 18:30:34]

Description was changed from

==========
mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG=629605
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG=629605
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[msw, 2016-08-02 18:30:34]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-08-02 18:30:57]

+TBR sky for mechanical chrome/* changes.

[commit-bot: I haz the power, 2016-08-02 19:38:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 19:38:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-08-02 21:59:13]

Hey James, I found the crash; take a look as you have time.

[msw, 2016-08-02 21:59:18]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-02 21:59:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2200893002/#ps80001
(title: "Fix mash browser test crash in GetMaxDisplaySizeInNative.")

[commit-bot: I haz the power, 2016-08-02 21:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 22:48:47]

Description was changed from

==========
mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG=629605
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG=629605
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-08-02 22:48:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-02 22:50:37]

Description was changed from

==========
mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG=629605
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org
==========

to

==========
mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG=629605
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362
Cr-Commit-Position: refs/heads/master@{#409360}
==========

[commit-bot: I haz the power, 2016-08-02 22:50:39]

Patchset 5 (id:??) landed as
https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362
Cr-Commit-Position: refs/heads/master@{#409360}