Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2200853002: MD Settings: Test transitioning between subpages on different pages (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@TestTransitions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CLOSED, needs to be made more robust. MD Settings: Test transitioning between subpages on different pages There was an bug in main_page_behavior.js that could result in all sections on the page becoming hidden. It's hard to trigger manually (lots of navigating between pages) but trivial to do with settings.navigateTo. The Manage A11y page on CrOS may cause problems without this fix. BUG=633262 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/settings_transitions_browsertest.js View 1 1 chunk +37 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (9 generated)
Dan Beam
lgtm it'd be nice if navigateTo() returned a Promise() and we could implement that promise ...
4 years, 4 months ago (2016-08-01 23:08:14 UTC) #4
Dan Beam
4 years, 4 months ago (2016-08-01 23:10:59 UTC) #5
it'd also potentially make our tests more concise to write

Powered by Google App Engine
This is Rietveld 408576698