C bindings: Implement _DeepCopy() & some unittests.

mojo/public/c/bindings/lib/union.c

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/c/bindings/union.h"
 
 #include <assert.h>
+#include <string.h>
 
 #include "mojo/public/c/bindings/lib/type_descriptor.h"
 
 size_t MojomUnion_ComputeSerializedSize(
     const struct MojomTypeDescriptorUnion* in_type_desc,
     const struct MojomUnionLayout* in_union_data) {
   assert(in_type_desc);
   assert(in_union_data);
 
   for (size_t i = 0; i < in_type_desc->num_entries; i++) {
@@ skipping 21 matching lines @@
   assert(in_buf_size >= sizeof(struct MojomUnionLayout));
 
   for (size_t i = 0; i < in_type_desc->num_entries; i++) {
     const struct MojomTypeDescriptorUnionEntry* entry =
         &(in_type_desc->entries[i]);
 
     if (inout_union->tag != entry->tag)
       continue;
 
     if (entry->elem_type == MOJOM_TYPE_DESCRIPTOR_TYPE_POD)
       continue;

[viettrungluu, 2016/08/03 16:43:24]

Should this really be |continue|? Or should it be |break|?

[vardhan, 2016/08/03 23:11:01]

It should be break, thanks!

 
     MojomType_DispatchEncodePointersAndHandles(
         entry->elem_type,
         entry->elem_descriptor,
         entry->nullable,
         &inout_union->data,
         in_buf_size - ((char*)&inout_union->data - (char*)inout_union),
         inout_handles_buffer);
+
+    break;
   }
 }
 
 void MojomUnion_DecodePointersAndHandles(
     const struct MojomTypeDescriptorUnion* in_type_desc,
     struct MojomUnionLayout* inout_union,
     uint32_t in_union_size,
     MojoHandle* inout_handles,
     uint32_t in_num_handles) {
   assert(in_union_size >= sizeof(struct MojomUnionLayout));
   assert(inout_handles != NULL || in_num_handles == 0);
 
   for (size_t i = 0; i < in_type_desc->num_entries; i++) {
     const struct MojomTypeDescriptorUnionEntry* entry =
         &(in_type_desc->entries[i]);
 
     if (inout_union->tag != entry->tag)
       continue;
 
     if (entry->elem_type == MOJOM_TYPE_DESCRIPTOR_TYPE_POD)
       continue;

[viettrungluu, 2016/08/03 16:43:24]

"

 
     MojomType_DispatchDecodePointersAndHandles(
         entry->elem_type,
         entry->elem_descriptor,
         entry->nullable,
         &inout_union->data,
         in_union_size - ((char*)&inout_union->data - (char*)inout_union),
         inout_handles,
         in_num_handles);
+
+    break;
   }
 }
 
 MojomValidationResult MojomUnion_Validate(
     const struct MojomTypeDescriptorUnion* in_type_desc,
     bool in_nullable,
     const struct MojomUnionLayout* in_union,
     uint32_t in_union_size,
     uint32_t in_num_handles,
     struct MojomValidationContext* inout_context) {
   for (size_t i = 0; i < in_type_desc->num_entries; i++) {
     const struct MojomTypeDescriptorUnionEntry* entry =
         &(in_type_desc->entries[i]);
 
     if (in_union->tag != entry->tag)
       continue;
 
     if (entry->elem_type == MOJOM_TYPE_DESCRIPTOR_TYPE_POD)
       continue;

[viettrungluu, 2016/08/03 16:43:24]

"

 
     if (!in_nullable && in_union->size != sizeof(struct MojomUnionLayout))
       return MOJOM_VALIDATION_UNEXPECTED_NULL_UNION;
 
-    MojomValidationResult result = MojomType_DispatchValidate(
+    return MojomType_DispatchValidate(
         entry->elem_type,
         entry->elem_descriptor,
         entry->nullable,
         &(in_union->data),
         in_union_size - ((char*)&(in_union->data) - (char*)in_union),
         in_num_handles,
         inout_context);
-    if (result != MOJOM_VALIDATION_ERROR_NONE)
-      return result;
   }
   return MOJOM_VALIDATION_ERROR_NONE;
 }
+
+bool MojomUnion_DeepCopy(struct MojomBuffer* buffer,
+                         const struct MojomTypeDescriptorUnion* in_type_desc,
+                         const struct MojomUnionLayout* in_union_data,
+                         struct MojomUnionLayout* out_union_data) {
+  memcpy(out_union_data, in_union_data, sizeof(struct MojomUnionLayout));
+
+  // Unions with size 0 are null.
+  if (in_union_data->size == 0)
+    return true;
+
+  for (size_t i = 0; i < in_type_desc->num_entries; i++) {
+    const struct MojomTypeDescriptorUnionEntry* entry =
+        &(in_type_desc->entries[i]);
+    if (in_union_data->tag != entry->tag)
+      continue;
+
+    // We should skip non-pointer types.
+    if (entry->elem_type == MOJOM_TYPE_DESCRIPTOR_TYPE_POD)
+      continue;

[viettrungluu, 2016/08/03 16:43:24]

"

(Or maybe |return true;|?)

+
+    return MojomType_DispatchDeepCopy(
+        buffer, entry->elem_type, entry->elem_descriptor,
+        &(in_union_data->data), &(out_union_data->data));
+  }
+
+  return true;

[viettrungluu, 2016/08/03 16:43:24]

Hmmm, returning true is a little odd: It means that (module the POD stuff above,
which seems dubious to me) in_union_data->tag is unknown (which, depending on
where in_union_data came from, may just mean that it's an instance of a future
version of the union).

But the result is that you didn't know what to do, and you didn't do a deep
copy, even if you should have.

[vardhan, 2016/08/03 23:11:01]

My assumption was that it shouldn't fail, but discussed offline: it should fail.

+}