GN: build sfntly, icu, harfbuzz

GN: build sfntly, icu, harfbuzz

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200833010

Committed: https://skia.googlesource.com/skia/+/19a9720978700a24efed8dda7e0935ea2b7338c4

[hal.canary, 2016-08-03 19:56:44]

Description was changed from

==========
GN: build sfntly, icu, harfbuzz

BUG=skia:
==========

to

==========
GN: build sfntly, icu, harfbuzz

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200833010
==========

[hal.canary, 2016-08-03 19:57:48]

halcanary@google.com changed reviewers:
+ herb@google.com, mtklein@google.com

[hal.canary, 2016-08-03 19:57:48]

WIP, need to test on mac, (windows?)

is this stylistically okay?

[hal.canary, 2016-08-03 19:58:12]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 19:58:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-08-03 20:06:51]

https://codereview.chromium.org/2200833010/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/BUILD.gn#newcode177
BUILD.gn:177: "//third_party/sfntly",
please run gn fmt --in-place on all your changed files

https://codereview.chromium.org/2200833010/diff/1/gn/BUILD.gn
File gn/BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/gn/BUILD.gn#newcode12
gn/BUILD.gn:12: config("nortti") {
no-rtti or no_rtti?

https://codereview.chromium.org/2200833010/diff/1/third_party/harfbuzz/BUILD.gn
File third_party/harfbuzz/BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/third_party/harfbuzz/BUILD....
third_party/harfbuzz/BUILD.gn:19: include_dirs = [ ".",
"../externals/harfbuzz/src" ]
no need

https://codereview.chromium.org/2200833010/diff/1/third_party/harfbuzz/BUILD....
third_party/harfbuzz/BUILD.gn:21: "../icu",
"//third_party/icu"

https://codereview.chromium.org/2200833010/diff/1/third_party/harfbuzz/BUILD....
third_party/harfbuzz/BUILD.gn:61: }
testonly?

https://codereview.chromium.org/2200833010/diff/1/third_party/icu/BUILD.gn
File third_party/icu/BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/third_party/icu/BUILD.gn#ne...
third_party/icu/BUILD.gn:12: configs = [ "//gn:default" ]
configs -= [ "//gn:no-rtti" ]

https://codereview.chromium.org/2200833010/diff/1/third_party/icu/BUILD.gn#ne...
third_party/icu/BUILD.gn:16: "HAVE_DLOPEN=0",
?

https://codereview.chromium.org/2200833010/diff/1/third_party/icu/BUILD.gn#ne...
third_party/icu/BUILD.gn:18: include_dirs = [ "../externals/icu/source/common" ]
no need

https://codereview.chromium.org/2200833010/diff/1/third_party/sfntly/BUILD.gn
File third_party/sfntly/BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/third_party/sfntly/BUILD.gn...
third_party/sfntly/BUILD.gn:15: deps = [ "../icu" ]
"//third_party/icu"

[commit-bot: I haz the power, 2016-08-03 20:08:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:08:03]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[hal.canary, 2016-08-03 21:26:14]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 21:26:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-08-03 21:33:50]

lgtm

[hal.canary, 2016-08-03 21:36:00]

https://codereview.chromium.org/2200833010/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/BUILD.gn#newcode177
BUILD.gn:177: "//third_party/sfntly",
On 2016/08/03 20:06:50, mtklein wrote:
> please run gn fmt --in-place on all your changed files

Done.

https://codereview.chromium.org/2200833010/diff/1/gn/BUILD.gn
File gn/BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/gn/BUILD.gn#newcode12
gn/BUILD.gn:12: config("nortti") {
On 2016/08/03 20:06:50, mtklein wrote:
> no-rtti or no_rtti?

Done.  no_rtti matches chrome use.

https://codereview.chromium.org/2200833010/diff/1/third_party/harfbuzz/BUILD.gn
File third_party/harfbuzz/BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/third_party/harfbuzz/BUILD....
third_party/harfbuzz/BUILD.gn:19: include_dirs = [ ".",
"../externals/harfbuzz/src" ]
On 2016/08/03 20:06:50, mtklein wrote:
> no need

Done.

https://codereview.chromium.org/2200833010/diff/1/third_party/harfbuzz/BUILD....
third_party/harfbuzz/BUILD.gn:21: "../icu",
On 2016/08/03 20:06:50, mtklein wrote:
> "//third_party/icu"

Done.

https://codereview.chromium.org/2200833010/diff/1/third_party/harfbuzz/BUILD....
third_party/harfbuzz/BUILD.gn:61: }
On 2016/08/03 20:06:50, mtklein wrote:
> testonly?

Done.

https://codereview.chromium.org/2200833010/diff/1/third_party/icu/BUILD.gn
File third_party/icu/BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/third_party/icu/BUILD.gn#ne...
third_party/icu/BUILD.gn:12: configs = [ "//gn:default" ]
On 2016/08/03 20:06:50, mtklein wrote:
> configs -= [ "//gn:no-rtti" ]

Done.

https://codereview.chromium.org/2200833010/diff/1/third_party/icu/BUILD.gn#ne...
third_party/icu/BUILD.gn:16: "HAVE_DLOPEN=0",
On 2016/08/03 20:06:50, mtklein wrote:
> ?

Done.

https://codereview.chromium.org/2200833010/diff/1/third_party/icu/BUILD.gn#ne...
third_party/icu/BUILD.gn:18: include_dirs = [ "../externals/icu/source/common" ]
On 2016/08/03 20:06:50, mtklein wrote:
> no need

Done.

https://codereview.chromium.org/2200833010/diff/1/third_party/sfntly/BUILD.gn
File third_party/sfntly/BUILD.gn (right):

https://codereview.chromium.org/2200833010/diff/1/third_party/sfntly/BUILD.gn...
third_party/sfntly/BUILD.gn:15: deps = [ "../icu" ]
On 2016/08/03 20:06:50, mtklein wrote:
> "//third_party/icu"

Done.

[hal.canary, 2016-08-03 21:36:09]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-08-03 21:36:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-03 21:45:46]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-08-03 22:08:22]

Description was changed from

==========
GN: build sfntly, icu, harfbuzz

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200833010
==========

to

==========
GN: build sfntly, icu, harfbuzz

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200833010

Committed:
https://skia.googlesource.com/skia/+/19a9720978700a24efed8dda7e0935ea2b7338c4
==========

[commit-bot: I haz the power, 2016-08-03 22:08:23]

Committed patchset #5 (id:100001) as
https://skia.googlesource.com/skia/+/19a9720978700a24efed8dda7e0935ea2b7338c4