Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2200833006: MacViews: Bump up the default font sizes for dialogs to 12pt. (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Bump up the default font sizes for dialogs to 12pt. Previously we used 11pt ([NSFont smallSystemFontSize]), to be consistent with the Cocoa bookmarks bubble. However, other Cocoa dialogs are using 12pt, and the latest cross-platform UI specs are converging on 12pt. (There's also general agreement that 11pt it too small). Since the "Base" font on Mac is [NSFont systemFontSize] -- 13pt -- we still need to adjust it compared to other platforms in ui/base/default_style.h. Cocoa UI isn't using these constants yet, so this only affects MacViews dialogs. BUG=632210, 564879, 630478 Committed: https://crrev.com/5e644cd132e1d7b288e0d2bbb9ea34e9a0a50ab6 Cr-Commit-Position: refs/heads/master@{#409633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M ui/base/default_style.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tapted
Hi avi, please take a look
4 years, 4 months ago (2016-08-03 11:47:56 UTC) #6
Avi (use Gerrit)
lgtm ok
4 years, 4 months ago (2016-08-03 14:46:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200833006/1
4 years, 4 months ago (2016-08-03 21:45:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 21:49:43 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 21:51:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e644cd132e1d7b288e0d2bbb9ea34e9a0a50ab6
Cr-Commit-Position: refs/heads/master@{#409633}

Powered by Google App Engine
This is Rietveld 408576698