Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2200763002: Fix fake_specs.py, update recipe expectation (Closed)

Created:
4 years, 4 months ago by borenet2
Modified:
4 years, 4 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanup
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2057 lines, -120 lines) Patch
M infra/bots/gen_buildbot_specs.py View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipe_modules/core/fake_specs.py View 1 2 chunks +31 lines, -28 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-x86_64-Debug-GN.json View 5 chunks +15 lines, -5 lines 0 comments Download
M tools/buildbot_spec.json View 1 31 chunks +1658 lines, -86 lines 0 comments Download
M tools/dm_flags.json View 1 22 chunks +352 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
borenet
4 years, 4 months ago (2016-08-03 16:48:31 UTC) #3
rmistry
lgtm
4 years, 4 months ago (2016-08-03 16:51:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200763002/20001
4 years, 4 months ago (2016-08-03 16:52:05 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 17:10:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9e3d3d8b363edcdd81a13b2be046152c6bb839cd

Powered by Google App Engine
This is Rietveld 408576698