Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2200733002: [interpreter] Elide OSR polling from fake loops. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Elide OSR polling from fake loops. This makes sure we are not inserting {OsrPoll} instructions for any statements that are not actually loops and have no back edges. Without back edges the {BytecodeGraphBuilder} is unable to deduce loop ranges and hence cannot construct a graph for OSR entry. R=neis@chromium.org TEST=mjsunit/regress/regress-5252 BUG=v8:5252 Committed: https://crrev.com/962fd4ae4bd3f2a7a4b7298e1e77e65234b6b5c5 Cr-Commit-Position: refs/heads/master@{#38233}

Patch Set 1 #

Patch Set 2 : Addressed comments. #

Patch Set 3 : Recement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/control-flow-builders.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/interpreter/control-flow-builders.cc View 1 1 chunk +11 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-5252.js View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-01 16:40:46 UTC) #1
Michael Starzinger
Addressed offline comments. Thanks, great suggestions! PTAL.
4 years, 4 months ago (2016-08-02 08:24:07 UTC) #6
neis
lgtm
4 years, 4 months ago (2016-08-02 08:29:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200733002/40001
4 years, 4 months ago (2016-08-02 09:14:27 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 09:16:11 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 09:17:05 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/962fd4ae4bd3f2a7a4b7298e1e77e65234b6b5c5
Cr-Commit-Position: refs/heads/master@{#38233}

Powered by Google App Engine
This is Rietveld 408576698