Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220073002: Turns on use_mojo for android (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Patch Set 3 : dont build mojo for webview yet #

Patch Set 4 : attempt LazyInstance fix #

Patch Set 5 : printf #

Patch Set 6 : explicitly call initi/shutdown for android #

Patch Set 7 : deped on content_app_browser #

Patch Set 8 : missing ] #

Patch Set 9 : == #

Patch Set 10 : move content_browser dep #

Patch Set 11 : content_app_both #

Patch Set 12 : merge to trunk #

Patch Set 13 : add export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/app/mojo/mojo_init.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +11 lines, -1 line 0 comments Download
M content/test/content_test_launcher.cc View 1 2 3 4 5 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 28 (0 generated)
sky
6 years, 8 months ago (2014-03-31 23:42:18 UTC) #1
darin (slow to review)
LGTM
6 years, 8 months ago (2014-04-01 00:11:05 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-01 15:35:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/220073002/20001
6 years, 8 months ago (2014-04-01 15:35:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 17:03:42 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=59968
6 years, 8 months ago (2014-04-01 17:03:43 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-01 21:16:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/220073002/40001
6 years, 8 months ago (2014-04-01 22:31:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/220073002/40001
6 years, 8 months ago (2014-04-02 02:03:06 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 12:15:10 UTC) #10
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 8 months ago (2014-04-02 12:15:11 UTC) #11
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-02 14:44:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/220073002/60001
6 years, 8 months ago (2014-04-02 14:45:16 UTC) #13
sky
Ok, I think this is finally going to pass the android bot (not webview yet). ...
6 years, 8 months ago (2014-04-02 23:25:51 UTC) #14
jam
lgtm
6 years, 8 months ago (2014-04-02 23:49:17 UTC) #15
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-02 23:59:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/220073002/200001
6 years, 8 months ago (2014-04-03 00:01:47 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 00:02:08 UTC) #18
commit-bot: I haz the power
Failed to apply patch for build/common.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-03 00:02:08 UTC) #19
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-03 14:38:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/220073002/220001
6 years, 8 months ago (2014-04-03 14:39:07 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 16:14:26 UTC) #22
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=129495
6 years, 8 months ago (2014-04-03 16:14:26 UTC) #23
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-03 16:36:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/220073002/240001
6 years, 8 months ago (2014-04-03 16:37:25 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 20:28:15 UTC) #26
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 20:28:16 UTC) #27
sky
6 years, 8 months ago (2014-04-03 20:39:36 UTC) #28
Message was sent while issue was closed. 
Committed patchset #13 manually as r261519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698