Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issue 2200703002: chromeos: Try to avoid shutdown crash in BootTimesRecorder. (Closed)

Created:
4 years, 4 months ago by Daniel Erat
Modified:
4 years, 4 months ago
Reviewers:
achuithb, Sami
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Try to avoid shutdown crash in BootTimesRecorder. Call BrowserThread::IsMessageLoopValid() (which bails out if the BrowserThreadGlobals singleton is uninitialized) before calling BrowserThread::CurrentlyOn() (which can apparently deref a null pointer if base::ThreadTaskRunnerHandle hasn't been initialized). BUG=609008 Committed: https://crrev.com/9972cd888b194adc1fc6de8bc6e53945846cb57e Cr-Commit-Position: refs/heads/master@{#410437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/chromeos/boot_times_recorder.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sami
Non-owner lgtm.
4 years, 4 months ago (2016-08-01 18:10:05 UTC) #3
Daniel Erat
4 years, 4 months ago (2016-08-08 19:11:47 UTC) #5
achuithb
lgtm
4 years, 4 months ago (2016-08-08 19:19:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200703002/1
4 years, 4 months ago (2016-08-08 19:20:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:29:12 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:31:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9972cd888b194adc1fc6de8bc6e53945846cb57e
Cr-Commit-Position: refs/heads/master@{#410437}

Powered by Google App Engine
This is Rietveld 408576698