ash: Rename "Autohide launcher" item.

chrome/common/chrome_switches.cc

Index: chrome/common/chrome_switches.cc
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc
index 14665c048187f720b667a63dbf34a6cc6573d84b..6e2fab76e966b305ea976cdcd6e40596fb5a41dc 100644
--- a/chrome/common/chrome_switches.cc
+++ b/chrome/common/chrome_switches.cc
@@ -1252,7 +1252,7 @@ const char kShowAppList[]                   = "show-app-list";
 // See kHideIcons.
 const char kShowIcons[]                     = "show-icons";
 
-// If true the alignment of the launcher can be changed.
+// If true the alignment of the launcher/shelf can be changed.
 const char kShowLauncherAlignmentMenu[]     = "show-launcher-alignment-menu";

[xiyuan, 2013/08/03 07:50:32]

Change in PS #1 is correct (except for a nit to align the assignment op).

I should have been more clear. For about flags, the internal name is important
as it is stored in the prefs to track the enabled experiment. When chrome runs,
it gets the list of the experiment, which is a list of internal name strings and
translates it into switches. So we can change the switch name but not the
internal flag name.

[tfarina, 2013/08/03 23:01:44]

Xiyuan, what I can not change is "show-launcher-alignment-menu"? It should stay
that way.

But can I change kShowLauncherAlignmentMenu to kShowShelfAlignmentMenu?

[xiyuan, 2013/08/03 23:59:34]

Yep. That's what I meant. 

"show-launcher-alignment-menu" as a flag's internal name should stay unchanged.
And we are free to change its underlying switch, i.e. you can change
kShowLauncherAlignmentMenu to kShowShelfAlignmentMenu.

[tfarina, 2013/08/04 02:51:35]

Done.

 
 // Marks a renderer as the signin process.