Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2437)

Unified Diff: content/shell/browser/shell_browser_main_parts.h

Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_browser_main_parts.h
diff --git a/content/shell/browser/shell_browser_main_parts.h b/content/shell/browser/shell_browser_main_parts.h
index e245404a09471fbd8bef69a16c53abe158b62e38..81e7e21a17e8c5ca4238a1ad45b9aa0519af149d 100644
--- a/content/shell/browser/shell_browser_main_parts.h
+++ b/content/shell/browser/shell_browser_main_parts.h
@@ -13,9 +13,13 @@
#include "content/public/common/main_function_params.h"
#include "content/shell/browser/shell_browser_context.h"
+namespace base {
+class Thread;
+}
+
#if defined(OS_ANDROID)
namespace breakpad {
-class CrashDumpManager;
+class CrashDumpObserver;
}
#endif
@@ -61,9 +65,6 @@ class ShellBrowserMainParts : public BrowserMainParts {
}
private:
-#if defined(OS_ANDROID)
- std::unique_ptr<breakpad::CrashDumpManager> crash_dump_manager_;
-#endif
std::unique_ptr<net::NetLog> net_log_;
std::unique_ptr<ShellBrowserContext> browser_context_;
std::unique_ptr<ShellBrowserContext> off_the_record_browser_context_;
@@ -72,6 +73,10 @@ class ShellBrowserMainParts : public BrowserMainParts {
const MainFunctionParams parameters_;
bool run_message_loop_;
+#if defined(OS_ANDROID)
+ std::unique_ptr<breakpad::CrashDumpObserver> crash_dump_observer_;
+#endif
+
DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts);
};
« no previous file with comments | « content/shell/browser/layout_test/layout_test_browser_main_parts.h ('k') | content/shell/browser/shell_browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698