Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chromecast/browser/cast_browser_main_parts.cc

Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_browser_main_parts.cc
diff --git a/chromecast/browser/cast_browser_main_parts.cc b/chromecast/browser/cast_browser_main_parts.cc
index fccad156ac79b362a9013c3a6c40c31d6151c1c6..0211c69aaa40e076d8792fd0c4bdfcbc35eed64c 100644
--- a/chromecast/browser/cast_browser_main_parts.cc
+++ b/chromecast/browser/cast_browser_main_parts.cc
@@ -39,6 +39,7 @@
#include "chromecast/browser/pref_service_helper.h"
#include "chromecast/browser/url_request_context_factory.h"
#include "chromecast/chromecast_features.h"
+#include "chromecast/common/global_descriptors.h"
#include "chromecast/common/platform_client_auth.h"
#include "chromecast/media/base/key_systems_common.h"
#include "chromecast/media/base/media_resource_tracker.h"
@@ -294,6 +295,9 @@ CastBrowserMainParts::~CastBrowserMainParts() {
media_thread_->task_runner()->DeleteSoon(
FROM_HERE, media_pipeline_backend_manager_.release());
}
+#else
+ breakpad::CrashDumpObserver::GetInstance()->UnregisterClient(
+ crash_dump_manager_.get());
#endif // !defined(OS_ANDROID)
}
@@ -387,8 +391,10 @@ int CastBrowserMainParts::PreCreateThreads() {
if (!chromecast::CrashHandler::GetCrashDumpLocation(&crash_dumps_dir)) {
LOG(ERROR) << "Could not find crash dump location.";
}
- cast_browser_process_->SetCrashDumpManager(
- base::MakeUnique<breakpad::CrashDumpManager>(crash_dumps_dir));
+ crash_dump_manager_ = base::MakeUnique<breakpad::CrashDumpManager>(
+ crash_dumps_dir, kAndroidMinidumpDescriptor);
+ breakpad::CrashDumpObserver::GetInstance()->RegisterClient(
+ crash_dump_manager_.get());
#else
base::FilePath home_dir;
CHECK(PathService::Get(DIR_CAST_HOME, &home_dir));

Powered by Google App Engine
This is Rietveld 408576698