Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: content/shell/browser/shell_browser_main_parts.h

Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cast compile error Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_browser_main_parts.h
diff --git a/content/shell/browser/shell_browser_main_parts.h b/content/shell/browser/shell_browser_main_parts.h
index a11e961d7ff03f449c97a2d3e193056c81a63472..44ad24046d31fc399deece41097e4791995bb179 100644
--- a/content/shell/browser/shell_browser_main_parts.h
+++ b/content/shell/browser/shell_browser_main_parts.h
@@ -13,16 +13,16 @@
#include "content/public/common/main_function_params.h"
#include "content/shell/browser/shell_browser_context.h"
+namespace base {
+class Thread;
+}
+
#if defined(OS_ANDROID)
namespace breakpad {
class CrashDumpManager;
}
#endif
-namespace base {
-class Thread;
-}
-
namespace devtools_http_handler {
class DevToolsHttpHandler;
}
@@ -73,9 +73,6 @@ class ShellBrowserMainParts : public BrowserMainParts {
}
private:
-#if defined(OS_ANDROID)
- std::unique_ptr<breakpad::CrashDumpManager> crash_dump_manager_;
-#endif
std::unique_ptr<net::NetLog> net_log_;
std::unique_ptr<ShellBrowserContext> browser_context_;
std::unique_ptr<ShellBrowserContext> off_the_record_browser_context_;
@@ -87,6 +84,10 @@ class ShellBrowserMainParts : public BrowserMainParts {
std::unique_ptr<devtools_http_handler::DevToolsHttpHandler>
devtools_http_handler_;
+#if defined(OS_ANDROID)
+ std::unique_ptr<breakpad::CrashDumpManager> crash_dump_manager_;
+#endif
+
DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts);
};

Powered by Google App Engine
This is Rietveld 408576698