chrome/browser/chrome_content_browser_client.cc - Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cast compile error Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/aw_browser_terminator.cc ('K') | « chrome/browser/chrome_browser_main_android.cc ('k') | chromecast/browser/cast_browser_main_parts.h » ('j') | components/crash/content/browser/crash_dump_manager_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index c00b48914a3ccf4fe64d34460caac1e3c434b4a2..3b35d0357a918ba211cfd533ad10ad8881d78159 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -2619,18 +2619,8 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(

fd = ui::GetLocalePackFd(&(*regions)[kAndroidLocalePakDescriptor]);

mappings->Share(kAndroidLocalePakDescriptor, fd);

- if (breakpad::IsCrashReporterEnabled()) {

- base::File file =

- breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(

- child_process_id);

- if (file.IsValid()) {

- mappings->Transfer(kAndroidMinidumpDescriptor,

- base::ScopedFD(file.TakePlatformFile()));

- } else {

- LOG(ERROR) << "Failed to create file for minidump, crash reporting will "

- "be disabled for this process.";

- }

+ breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(

+ child_process_id, mappings);

base::FilePath app_data_path;

PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);