Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2200683002: Add --hot-reload-rollback test mode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 1747731c5a5de181f432e6159bedefdc712eabb0..bf6db43b48d3150c1ed514f670ed88d5bc8a8649 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -54,6 +54,7 @@ abstract class CompilerConfiguration {
bool useCps = configuration['cps_ir'];
bool useBlobs = configuration['use_blobs'];
bool hotReload = configuration['hot_reload'];
+ bool hotReloadRollback = configuration['hot_reload_rollback'];
switch (compiler) {
case 'dart2analyzer':
@@ -91,7 +92,8 @@ abstract class CompilerConfiguration {
isChecked: isChecked,
isHostChecked: isHostChecked,
useSdk: useSdk,
- hotReload: hotReload);
+ hotReload: hotReload,
+ hotReloadRollback: hotReloadRollback);
default:
throw "Unknown compiler '$compiler'";
}
@@ -152,16 +154,19 @@ abstract class CompilerConfiguration {
/// The "none" compiler.
class NoneCompilerConfiguration extends CompilerConfiguration {
final bool hotReload;
+ final bool hotReloadRollback;
NoneCompilerConfiguration(
{bool isDebug, bool isChecked, bool isHostChecked, bool useSdk,
- bool hotReload})
+ bool hotReload,
+ bool hotReloadRollback})
: super._subclass(
isDebug: isDebug,
isChecked: isChecked,
isHostChecked: isHostChecked,
useSdk: useSdk),
- this.hotReload = hotReload;
+ this.hotReload = hotReload,
+ this.hotReloadRollback = hotReloadRollback;
bool get hasCompiler => false;
@@ -180,6 +185,8 @@ class NoneCompilerConfiguration extends CompilerConfiguration {
}
if (hotReload) {
args.add('--hot-reload-test-mode');
+ } else if (hotReloadRollback) {
+ args.add('--hot-reload-rollback-test-mode');
}
return args
..addAll(vmOptions)
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698