Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2200673002: [turbofan] Switch inlining tests to global scope. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Switch inlining tests to global scope. This switches our inlining tests (i.e. cctest/test-run-inlining) to rely on global object instead of function context specialization, which is more in sync with what we are actually shipping. It will also allow us to test inlining with the BytecodeGraphBuilder without having to add support for function context specialization just for testing purposes. R=bmeurer@chromium.org TEST=cctest/test-run-inlining BUG=v8:5251 Committed: https://crrev.com/9ee6ca75d396c99d5bf9203ed22996a2e6028527 Cr-Commit-Position: refs/heads/master@{#38209}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -247 lines) Patch
M test/cctest/cctest.status View 1 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 29 chunks +135 lines, -241 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-01 12:33:24 UTC) #1
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-01 12:36:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200673002/20001
4 years, 4 months ago (2016-08-01 12:57:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 12:59:19 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 13:00:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ee6ca75d396c99d5bf9203ed22996a2e6028527
Cr-Commit-Position: refs/heads/master@{#38209}

Powered by Google App Engine
This is Rietveld 408576698