HeadlessDevToolsClientImpl::DispatchEvent to post a task

HeadlessDevToolsClientImpl::DispatchEvent to post a task

DevTools expects events to be processed asynchronously and if handlers
respond synchronously things can break.  This patch works around that
by posting a task to run the event handler.

BUG=546953
Committed: https://crrev.com/6f348930aacb2ef5432e6bc5671d3e50c0dd7dfb
Cr-Commit-Position: refs/heads/master@{#408976}

[alex clarke (OOO till 29th), 2016-08-01 10:37:09]

Description was changed from

==========
HeadlessDevToolsClientImpl::DispatchEvent to post a task

DevTools expects events to be processed asynchronously and if handlers
respond synchronously things can break.  This patch works around that
by posting a task to run the event handler.

BUG=546953
==========

to

==========
HeadlessDevToolsClientImpl::DispatchEvent to post a task

DevTools expects events to be processed asynchronously and if handlers
respond synchronously things can break.  This patch works around that
by posting a task to run the event handler.

BUG=546953
==========

[alex clarke (OOO till 29th), 2016-08-01 10:37:09]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2016-08-01 11:05:02]

lgtm with one question.

https://codereview.chromium.org/2200663002/diff/1/headless/lib/browser/headle...
File headless/lib/browser/headless_devtools_client_impl.cc (right):

https://codereview.chromium.org/2200663002/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_devtools_client_impl.cc:152: &it->second,
result_dict));
Might need to change the "auto it" above to "const auto& it" to make sure this
isn't pointing to a stack value.

https://codereview.chromium.org/2200663002/diff/1/headless/lib/headless_devto...
File headless/lib/headless_devtools_client_browsertest.cc (right):

https://codereview.chromium.org/2200663002/diff/1/headless/lib/headless_devto...
headless/lib/headless_devtools_client_browsertest.cc:530: bool
navigation_requested_ = false;
nit: private:

[alex clarke (OOO till 29th), 2016-08-01 15:37:02]

https://codereview.chromium.org/2200663002/diff/1/headless/lib/browser/headle...
File headless/lib/browser/headless_devtools_client_impl.cc (right):

https://codereview.chromium.org/2200663002/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_devtools_client_impl.cc:152: &it->second,
result_dict));
On 2016/08/01 11:05:02, Sami wrote:
> Might need to change the "auto it" above to "const auto& it" to make sure this
> isn't pointing to a stack value.

As discussed offline I did something similar to nail down the type.

https://codereview.chromium.org/2200663002/diff/1/headless/lib/headless_devto...
File headless/lib/headless_devtools_client_browsertest.cc (right):

https://codereview.chromium.org/2200663002/diff/1/headless/lib/headless_devto...
headless/lib/headless_devtools_client_browsertest.cc:530: bool
navigation_requested_ = false;
On 2016/08/01 11:05:02, Sami wrote:
> nit: private:

Done.

[alex clarke (OOO till 29th), 2016-08-01 15:37:06]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-08-01 15:37:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2200663002/#ps20001
(title: "Tweak for Sami")

[commit-bot: I haz the power, 2016-08-01 15:37:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 16:29:16]

Description was changed from

==========
HeadlessDevToolsClientImpl::DispatchEvent to post a task

DevTools expects events to be processed asynchronously and if handlers
respond synchronously things can break.  This patch works around that
by posting a task to run the event handler.

BUG=546953
==========

to

==========
HeadlessDevToolsClientImpl::DispatchEvent to post a task

DevTools expects events to be processed asynchronously and if handlers
respond synchronously things can break.  This patch works around that
by posting a task to run the event handler.

BUG=546953
==========

[commit-bot: I haz the power, 2016-08-01 16:29:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-01 16:32:13]

Description was changed from

==========
HeadlessDevToolsClientImpl::DispatchEvent to post a task

DevTools expects events to be processed asynchronously and if handlers
respond synchronously things can break.  This patch works around that
by posting a task to run the event handler.

BUG=546953
==========

to

==========
HeadlessDevToolsClientImpl::DispatchEvent to post a task

DevTools expects events to be processed asynchronously and if handlers
respond synchronously things can break.  This patch works around that
by posting a task to run the event handler.

BUG=546953

Committed: https://crrev.com/6f348930aacb2ef5432e6bc5671d3e50c0dd7dfb
Cr-Commit-Position: refs/heads/master@{#408976}
==========

[commit-bot: I haz the power, 2016-08-01 16:32:14]

Patchset 2 (id:??) landed as
https://crrev.com/6f348930aacb2ef5432e6bc5671d3e50c0dd7dfb
Cr-Commit-Position: refs/heads/master@{#408976}