third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp - Issue 2200613002: The HTML parser synchronously creates custom elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

Issue 2200613002: The HTML parser synchronously creates custom elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/parser/HTMLParserReentryPermit.h ('K') | « third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

index ff36b586a035cec8d33d12914b22a5cf36811420..55d203c8e2162a23f3322c6447f40e6eafcc6187 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

@@ -267,7 +267,7 @@ HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, Document& document,

#if ENABLE(ASSERT)

, m_isAttached(true)

#endif

- , m_tree(document, parserContentPolicy)

+ , m_tree(parser->reentryPermit(), document, parserContentPolicy)

, m_insertionMode(InitialMode)

, m_originalInsertionMode(InitialMode)

, m_shouldSkipLeadingNewline(false)

@@ -326,8 +326,9 @@ DEFINE_TRACE(HTMLTreeBuilder)

void HTMLTreeBuilder::detach()

{

#if ENABLE(ASSERT)

- // This call makes little sense in fragment mode, but for consistency

- // DocumentParser expects detach() to always be called before it's destroyed.

+ // This call makes little sense in fragment mode, but for

+ // consistency DocumentParser expects detach() to always be called

+ // before it's destroyed.

m_isAttached = false;

#endif

// HTMLConstructionSite might be on the callstack when detach() is called