third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js - Issue 2200613002: The HTML parser synchronously creates custom elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

Issue 2200613002: The HTML parser synchronously creates custom elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/custom-elements/spec/parsing.html ('K') | « third_party/WebKit/LayoutTests/custom-elements/spec/parsing.html ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

diff --git a/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js b/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

index 7a1c7196fe65276e536e5b269001cb878089c62f..114e1b00bc6ffb268a28a110e75a443962c4ef7d 100644

--- a/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

+++ b/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js

@@ -4,7 +4,7 @@ function create_window_in_test(t, srcdoc) {

f.srcdoc = srcdoc ? srcdoc : '';

f.onload = (event) => {

let w = f.contentWindow;

- t.add_cleanup(() => f.remove());

+ t.add_cleanup(() => f.parentNode && f.remove());

resolve(w);

};

document.body.appendChild(f);