Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2200593002: Revert of Fix bug with blank pages during navigation (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2197783002/ ) Reason for revert: Suspected for widespread NaCl plugin failures on waterfall since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504 Crashes with "Actual: "Plugin crashed. 'NaCl module crashed" It wasn't r408782, so I think it's gotta be this or r408781. Original issue's description: > Fix bug with blank pages during navigation > > This bug started after r408172. In some situations when navigating, the > SetNeedsBeginFrame messages that is sent from the > CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is > received by the RenderWidgetHostImpl while the RenderViewHost is swapped > out and before it has swapped back in. In these cases, if this message > is dropped, the renderer will never tick new frames and the tab will > freeze. This appears to be racy, as the renderer finds out that it is > visible and sends this message before the view host is swapped in. > > To fix this race, always allow the SetNeedsBeginFrame message to be > received while being swapped out so that the RenderWidgetHostView can be > in the correct state when it is swapped in. > > R=sievers@chromium.org > BUG=632276 > > Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20 > Cr-Commit-Position: refs/heads/master@{#408787} TBR=kenrb@chromium.org,sievers@chromium.org,enne@chromium.org NOTRY=true BUG=632276 Committed: https://crrev.com/ad648d7d920843e226b5f0aee2cf8e9662412413 Cr-Commit-Position: refs/heads/master@{#408899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/common/swapped_out_messages.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tapted
Created Revert of Fix bug with blank pages during navigation
4 years, 4 months ago (2016-08-01 01:34:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200593002/1
4 years, 4 months ago (2016-08-01 01:35:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200593002/1
4 years, 4 months ago (2016-08-01 01:51:26 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 01:54:28 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ad648d7d920843e226b5f0aee2cf8e9662412413 Cr-Commit-Position: refs/heads/master@{#408899}
4 years, 4 months ago (2016-08-01 01:56:31 UTC) #11
tapted
4 years, 4 months ago (2016-08-01 02:58:26 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2195253002/ by tapted@chromium.org.

The reason for reverting is: No dice - NaCl still crashing in
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui....

Powered by Google App Engine
This is Rietveld 408576698