Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220053002: Remove ExtensionService::GetInstalledExtensionByUrl(). (Closed)

Created:
6 years, 8 months ago by Devlin
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove ExtensionService::GetInstalledExtensionByUrl(). Replace with ExtensionRegistry::enabled_extensions().GetExtensionOrAppByUrl(). BUG=351891 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261389

Patch Set 1 #

Total comments: 1

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 chunk +14 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
Nice 'n small, no functional changes.
6 years, 8 months ago (2014-03-31 21:33:33 UTC) #1
Yoyo Zhou
LGTM https://codereview.chromium.org/220053002/diff/1/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (left): https://codereview.chromium.org/220053002/diff/1/chrome/browser/extensions/extension_service.cc#oldcode280 chrome/browser/extensions/extension_service.cc:280: return registry_->enabled_extensions().GetExtensionOrAppByURL(url); Ugh, so this function had a ...
6 years, 8 months ago (2014-03-31 21:36:32 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 8 months ago (2014-04-02 17:35:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/220053002/10001
6 years, 8 months ago (2014-04-02 17:37:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 02:23:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=61330
6 years, 8 months ago (2014-04-03 02:23:06 UTC) #6
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 8 months ago (2014-04-03 13:46:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/220053002/10001
6 years, 8 months ago (2014-04-03 13:47:16 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 14:53:45 UTC) #9
Message was sent while issue was closed. 
Change committed as 261389

Powered by Google App Engine
This is Rietveld 408576698