components/translate/core/browser/translate_browser_metrics_unittest.cc - Issue 2200493002: using ulp to improve TranslateManager GetTargetLanguage() and InitiateTranslation()

Unified Diff: components/translate/core/browser/translate_browser_metrics_unittest.cc

Issue 2200493002: using ulp to improve TranslateManager GetTargetLanguage() and InitiateTranslation() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unit tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/core/browser/translate_browser_metrics.h ('k') | components/translate/core/browser/translate_manager.h » ('j') | components/translate/core/browser/translate_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_browser_metrics_unittest.cc

diff --git a/components/translate/core/browser/translate_browser_metrics_unittest.cc b/components/translate/core/browser/translate_browser_metrics_unittest.cc

index ef0fb141ac2939551ae52382f3e81ed9889ff54e..0304f7eaa39ac84f036865dff38861eca5bd664c 100644

--- a/components/translate/core/browser/translate_browser_metrics_unittest.cc

+++ b/components/translate/core/browser/translate_browser_metrics_unittest.cc

@@ -40,6 +40,7 @@ class MetricsRecorder {

int expected_accept_languages,

int expected_auto_by_config,

int expected_auto_by_link,

+ int expected_language_in_ulp,

int expected_show_infobar) {

Snapshot();

@@ -82,6 +83,9 @@ class MetricsRecorder {

EXPECT_EQ(expected_auto_by_link,

GetCountWithoutSnapshot(translate::TranslateBrowserMetrics::

INITIATION_STATUS_AUTO_BY_LINK));

+ EXPECT_EQ(expected_language_in_ulp,

+ GetCountWithoutSnapshot(translate::TranslateBrowserMetrics::

+ INITIATION_STATUS_LANGUAGE_IN_ULP));

EXPECT_EQ(expected_show_infobar,

GetCountWithoutSnapshot(translate::TranslateBrowserMetrics::

INITIATION_STATUS_SHOW_INFOBAR));

@@ -132,46 +136,49 @@ TEST(TranslateBrowserMetricsTest, ReportInitiationStatus) {

MetricsRecorder recorder(translate::TranslateBrowserMetrics::GetMetricsName(

translate::TranslateBrowserMetrics::UMA_INITIATION_STATUS));

- recorder.CheckInitiationStatus(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_DISABLED_BY_PREFS);

- recorder.CheckInitiationStatus(1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_DISABLED_BY_SWITCH);

- recorder.CheckInitiationStatus(1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_DISABLED_BY_CONFIG);

- recorder.CheckInitiationStatus(1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_DISABLED_BY_KEY);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::

INITIATION_STATUS_LANGUAGE_IS_NOT_SUPPORTED);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::

INITIATION_STATUS_MIME_TYPE_IS_NOT_SUPPORTED);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::

INITIATION_STATUS_URL_IS_NOT_SUPPORTED);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_ACCEPT_LANGUAGES);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_AUTO_BY_CONFIG);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_AUTO_BY_LINK);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0);

+ translate::TranslateBrowserMetrics::ReportInitiationStatus(

groby-ooo-7-16 2016/08/02 00:38:20 I really don't think this entire test makes sense

ftang 2016/08/03 02:01:17 What do you suggest me to do wi this? Not making c

groby-ooo-7-16 2016/08/04 02:33:42 Yes, I really think we can skip this. It's a lot o

+ translate::TranslateBrowserMetrics::INITIATION_STATUS_LANGUAGE_IN_ULP);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0);

translate::TranslateBrowserMetrics::ReportInitiationStatus(

translate::TranslateBrowserMetrics::INITIATION_STATUS_SHOW_INFOBAR);

- recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1);

+ recorder.CheckInitiationStatus(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1);

}

TEST(TranslateBrowserMetricsTest, ReportLanguageDetectionError) {