using ulp to improve TranslateManager GetTargetLanguage() and InitiateTranslation()

components/translate/core/browser/translate_prefs.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_
 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_
 
 #include <stddef.h>
 
 #include <string>
@@ skipping 60 matching lines @@
   std::string language_;
   size_t max_denial_count_;
   base::ListValue* time_list_;  // Weak, owned by the containing prefs service.
 };
 
 // The wrapper of PrefService object for Translate.
 //
 // It is assumed that |prefs_| is alive while this instance is alive.
 class TranslatePrefs {
  public:
+  static const char kPrefLanguageProfile[];
   static const char kPrefTranslateSiteBlacklist[];
   static const char kPrefTranslateWhitelists[];
   static const char kPrefTranslateDeniedCount[];
   static const char kPrefTranslateIgnoredCount[];
   static const char kPrefTranslateAcceptedCount[];
   static const char kPrefTranslateBlockedLanguages[];
   static const char kPrefTranslateLastDeniedTimeForLanguage[];
   static const char kPrefTranslateTooOftenDeniedForLanguage[];
 
   // |preferred_languages_pref| is only used on Chrome OS, other platforms must
@@ skipping 67 matching lines @@
   void GetLanguageList(std::vector<std::string>* languages) const;
 
   // Updates the language list of the language settings.
   void UpdateLanguageList(const std::vector<std::string>& languages);
 
   bool CanTranslateLanguage(TranslateAcceptLanguages* accept_languages,
                             const std::string& language);
   bool ShouldAutoTranslate(const std::string& original_language,
                            std::string* target_language);
 
+  // Language and probability pair.
+  typedef std::pair<std::string, double> LanguageAndProbability;
+  typedef std::vector<LanguageAndProbability> LanguageAndProbabilityList;
+
+  // Output the User Profile Profile's (ULP) "reading list" into |list| as
+  // ordered list of <string, double> pair. Return the confidence of the list

[groby-ooo-7-16, 2016/08/04 02:33:43]

What is the list ordered by? I assume the double?

[ftang, 2016/08/05 04:45:28]

Done.

+  // or 0.0 if there no ULP "reading list".
+  virtual double GetReadingFromUserLanguageProfile(

[groby-ooo-7-16, 2016/08/04 02:33:42]

Please don't make this virtual (relates to the "no mock" comment)

[ftang, 2016/08/05 04:45:28]

Done.

+      LanguageAndProbabilityList* list) const;
+
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
   static void MigrateUserPrefs(PrefService* user_prefs,
                                const char* accept_languages_pref);
 
  private:
   friend class TranslatePrefsTest;
 
   // Merges two language sets to migrate to the language setting UI.
   static void CreateBlockedLanguages(
       std::vector<std::string>* blocked_languages,
@@ skipping 30 matching lines @@
   PrefService* prefs_;  // Weak.
 
   std::string country_;  // The country the app runs in.
 
   DISALLOW_COPY_AND_ASSIGN(TranslatePrefs);
 };
 
 }  // namespace translate
 
 #endif  // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_PREFS_H_