Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/settings/a11y_page/manage_a11y_page.html

Issue 2200463002: Reorganize accessibility settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« chrome/browser/resources/settings/a11y_page/compiled_resources2.gyp ('K') | « chrome/browser/resources/settings/a11y_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/a11y_page/manage_a11y_page.js » ('j') | chrome/browser/resources/settings/a11y_page/manage_a11y_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="/controls/settings_checkbox.html">
3 <link rel="import" href="/route.html">
michaelpg 2016/07/29 22:14:20 import /i18n_setup.html for load_time_data.js (inc
dmazzoni 2016/08/01 18:45:23 Done
4 <link rel="import" href="/settings_shared_css.html">
5
6 <dom-module id="settings-manage-a11y-page">
7 <template>
8 <style include="settings-shared">
9 div.indented {
10 -webkit-margin-start: 20px;
11 }
12 h3 {
michaelpg 2016/07/29 22:14:20 nit: blank line between rules
dmazzoni 2016/08/01 18:45:23 Done
13 color: rgb(90, 90, 90);
michaelpg 2016/07/29 22:14:21 Note: I asked in the bug whether this <h3> should
dmazzoni 2016/08/01 18:45:23 This definitely seems like it ought to be a headin
14 font-weight: 500;
15 }
16 .settings-box iron-icon {
17 -webkit-margin-end: var(--iron-icon-spacing);
18 }
19 .settings-box settings-checkbox {
20 flex-grow: 1;
21 }
22 </style>
23 <div class="settings-box row first">
24 <span>
25 $i18n{a11yExplanation}
26 <a href="$i18nRaw{a11yLearnMoreUrl}" target="_blank">
27 $i18n{learnMore}
28 </a>
29 </span>
30 </div>
31
32 <div class="settings-box block">
33 <h3>Text-to-Speech</h3>
34 <div class="settings-box first indented">
35 <settings-checkbox pref="{{prefs.settings.accessibility}}"
36 label="$i18n{chromeVoxLabel}">
michaelpg 2016/07/29 22:14:21 4-space indents, throughout
dmazzoni 2016/08/01 18:45:23 Done
37 </settings-checkbox>
38 <paper-icon-button icon="settings:settings" on-tap="onChromeVoxSettingsT ap_">
michaelpg 2016/07/29 22:14:21 wrap long lines, throughout
dmazzoni 2016/08/01 18:45:23 Done
39 </paper-icon-button>
40 </div>
41 <template is="dom-if" if="[[showExperimentalFeatures_]]">
42 <div class="settings-box first indented">
43 <settings-checkbox pref="{{prefs.settings.a11y.select_to_speak}}"
44 label="Select-to-speak"
45 sub-label="Hold down Search and click or drag to speak anything">
46 </settings-checkbox>
47 </div>
48 </template>
49
50 <h3>Display</h3>
51 <div class="settings-box block first indented">
52 <settings-checkbox label="$i18n{highContrastLabel}"
53 pref="{{prefs.settings.a11y.high_contrast_enabled}}">
54 </settings-checkbox>
55 <settings-checkbox label="$i18n{screenMagnifierLabel}"
56 pref="{{prefs.settings.a11y.screen_magnifier}}">
57 </settings-checkbox>
58 </div>
59 <div class="settings-box two-line indented" on-tap="onDisplayTap_" actiona ble>
60 <iron-icon icon="settings:desktop-windows"></iron-icon>
61 <div class="start">
62 <div>Open display device settings</div>
63 <div class="secondary">Allows you to adjust your screen resolution</di v>
64 </div>
65 </div>
66 <div class="settings-box two-line indented" on-tap="onAppearanceTap_"
67 actionable>
68 <iron-icon icon="settings:text-format"></iron-icon>
69 <div class="start">
70 <div>Open appearance settings</div>
71 <div class="secondary">Customize your text size</div>
72 </div>
73 </div>
74
75 <h3>Keyboard</h3>
76 <div class="settings-box block first indented">
77 <settings-checkbox
78 pref="{{prefs.settings.a11y.sticky_keys_enabled}}"
79 label="$i18n{stickyKeysLabel}">
80 </settings-checkbox>
81 <settings-checkbox pref="{{prefs.settings.a11y.virtual_keyboard}}"
82 label="$i18n{onScreenKeyboardLabel}">
83 </settings-checkbox>
84 <settings-checkbox pref="{{prefs.settings.a11y.focus_highlight}}"
85 label="$i18n{focusHighlightLabel}">
86 </settings-checkbox>
87 <settings-checkbox pref="{{prefs.settings.a11y.caret_highlight}}"
88 label="$i18n{caretHighlightLabel}">
89 </settings-checkbox>
90 <template is="dom-if" if="[[showExperimentalFeatures_]]">
91 <settings-checkbox pref="{{prefs.settings.a11y.switch_access}}"
92 label="$i18n{switchAccessLabel}">
93 </settings-checkbox>
94 </template>
95 </div>
96 <div class="settings-box two-line indented" on-tap="onKeyboardTap_"
97 actionable>
98 <iron-icon icon="settings:keyboard"></iron-icon>
99 <div class="start">
100 <div>Open keyboard device settings</div>
101 <div class="secondary">Allows you to adjust your keyboard repeat rate, word prediction, and more</div>
102 </div>
103 </div>
104
105 <h3>Mouse and touchpad</h3>
106 <div class="settings-box block first indented">
107 <settings-checkbox label="$i18n{clickOnStopLabel}"
108 pref="{{prefs.settings.a11y.autoclick}}">
109 </settings-checkbox>
110 <div class="list-item settings-checkbox-spacer">
111 <div>$i18n{delayBeforeClickLabel}</div>
112 <select value="{{prefs.settings.a11y.autoclick_delay_ms::change}}">
michaelpg 2016/07/29 22:14:20 feel like upgrading this to a settings-dropdown-me
dmazzoni 2016/08/01 18:45:23 Looks like that was done in parallel. :)
michaelpg 2016/08/02 17:38:29 Oh... I reviewed that, too!
113 <option value="600">$i18n{delayBeforeClickExtremelyShort}</option>
114 <option value="800">$i18n{delayBeforeClickVeryShort}</option>
115 <option value="1000">$i18n{delayBeforeClickShort}</option>
116 <option value="2000">$i18n{delayBeforeClickLong}</option>
117 <option value="4000">$i18n{delayBeforeClickVeryLong}</option>
118 </select>
119 </div>
120 <settings-checkbox label="$i18n{tapDraggingLabel}"
121 pref="{{prefs.settings.touchpad.enable_tap_dragging}}">
122 </settings-checkbox>
123 <settings-checkbox label="$i18n{largeMouseCursorLabel}"
124 pref="{{prefs.settings.a11y.large_cursor_enabled}}">
125 </settings-checkbox>
126 <settings-checkbox pref="{{prefs.settings.a11y.cursor_highlight}}"
127 label="$i18n{cursorHighlightLabel}">
128 </settings-checkbox>
129 </div>
130 <div class="settings-box two-line indented" on-tap="onMouseTap_"
131 actionable>
132 <iron-icon icon="settings:mouse"></iron-icon>
133 <div class="start">
134 <div>Open mouse and touchpad device settings</div>
135 <div class="secondary">Allows you to enable/disable tap-to-click</div>
136 </div>
137 </div>
138
139 <h3>Audio</h3>
140 <div class="settings-box block first indented">
141 <settings-checkbox pref="{{prefs.settings.a11y.mono_audio}}"
142 label="$i18n{monoAudioLabel}">
143 </settings-checkbox>
144 </div>
145 </div>
146
147 <div class="settings-box two-line" on-tap="onMoreFeaturesTap_" actionable>
148 <div class="start">
149 <div>Add additional features</div>
150 <div class="secondary">Choose from the Chrome Web Store</div>
151 </div>
152 </div>
153
michaelpg 2016/07/29 22:14:21 nit: remove blank line
dmazzoni 2016/08/01 18:45:23 Done
154 </template>
155
michaelpg 2016/07/29 22:14:20 nit: remove blank line
dmazzoni 2016/08/01 18:45:23 Done
156 <script src="manage_a11y_page.js"></script>
157 </dom-module>
OLDNEW
« chrome/browser/resources/settings/a11y_page/compiled_resources2.gyp ('K') | « chrome/browser/resources/settings/a11y_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/a11y_page/manage_a11y_page.js » ('j') | chrome/browser/resources/settings/a11y_page/manage_a11y_page.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698