Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2200453002: [turbofan] Optimize CheckedInt32Mod with unknown power of 2 right hand side. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize CheckedInt32Mod with unknown power of 2 right hand side. We have a similar optimization for unchecked integer modulus, which already boosted some asm.js use cases. Now this optimization is almost as effcient as Crankshafts known power of 2 right hand side optimization for modulus, but it can still deal with any rhs (except 0), and doesn't require the interpreter to also collect known power of two rhs feedback. R=jarin@chromium.org Committed: https://crrev.com/b418b2c419429bdac1527fa1e32325e97e75a8ad Cr-Commit-Position: refs/heads/master@{#38187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -31 lines) Patch
M src/compiler/effect-control-linearizer.cc View 2 chunks +89 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-29 19:37:33 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the follow up fix for audio-oscillator that Michael asked me to take ...
4 years, 4 months ago (2016-07-30 17:58:40 UTC) #6
Jarin
lgtm
4 years, 4 months ago (2016-07-30 18:20:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200453002/1
4 years, 4 months ago (2016-07-30 19:48:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 20:08:48 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 20:12:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b418b2c419429bdac1527fa1e32325e97e75a8ad
Cr-Commit-Position: refs/heads/master@{#38187}

Powered by Google App Engine
This is Rietveld 408576698