Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2200413005: Update WebAudio layout tests for Android (arm32) (Closed)

Created:
4 years, 4 months ago by Raymond Toy
Modified:
4 years, 4 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebAudio layout tests for Android (arm32) Update thresholds and print precision appropriately so that these tests pass on Android. The audiobuffersource-loop-points test differs by at most 1 bit in the original reference so we're just adding an Android-specific result. These tests were run on a Galaxy Nexus and pass there. BUG=634165 TEST= Committed: https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5 Cr-Commit-Position: refs/heads/master@{#411076}

Patch Set 1 #

Patch Set 2 : Regenerate android audiobuffersource-loop-points result #

Patch Set 3 : Minor cleanups. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -68 lines) Patch
A + third_party/WebKit/LayoutTests/platform/android/webaudio/audiobuffersource-loop-points-expected.wav View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audiolistener-automation-position.html View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audiolistener-automation-position-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-setTargetAtTime-continuous.html View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-setTargetAtTime-continuous-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-update-value-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-update-value-attribute-expected.txt View 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/biquad-automation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/biquad-automation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/panner-automation-position.html View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/panner-automation-position-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-smoothing.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-smoothing-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Raymond Toy
PTAL.
4 years, 4 months ago (2016-08-04 17:19:25 UTC) #10
hongchan
lgtm
4 years, 4 months ago (2016-08-09 22:54:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200413005/40001
4 years, 4 months ago (2016-08-10 16:30:02 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 17:47:10 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 17:50:03 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3bccb8801019378b11d077e4f5589959998a81e5
Cr-Commit-Position: refs/heads/master@{#411076}

Powered by Google App Engine
This is Rietveld 408576698