Pass template files explicitly to Robolectric template processor.

third_party/robolectric/template_processor/src/org/chromium/testing/robolectric/template/ProcessRobolectricTemplate.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.testing.robolectric.template;
 
 import org.apache.velocity.Template;
 import org.apache.velocity.VelocityContext;
 import org.apache.velocity.app.Velocity;
 import org.apache.velocity.exception.VelocityException;
@@ skipping 16 matching lines @@
 
 /**
  * Class to process Robolectric template (*.vm) files using Apache Velocity.
  */
 public final class ProcessRobolectricTemplate {
 
     private ProcessRobolectricTemplate() {
     }
 
     public static void main(String[] args) {
+
         final ProcessTemplateArgParser parser = ProcessTemplateArgParser.parse(args);
 
         Velocity.setProperty(RuntimeConstants.RESOURCE_LOADER, "file");
         Velocity.setProperty(RuntimeConstants.FILE_RESOURCE_LOADER_PATH,
                 parser.getBaseTemplateDir().toString());
         Velocity.init();
 
         final VelocityContext context = new VelocityContext();
         final int api = parser.getApiLevel();
         context.put("api", api);
         if (api >= 21) {
             context.put("ptrClass", "long");
             context.put("ptrClassBoxed", "Long");
         } else {
             context.put("ptrClass", "int");
             context.put("ptrClassBoxed", "Integer");
         }
-
         try {
-            final PathMatcher templatePathMatcher =
-                    FileSystems.getDefault().getPathMatcher("glob:" + "**/*.vm");
-            Files.walkFileTree(parser.getBaseTemplateDir(), new SimpleFileVisitor<Path>() {

[mikecase (-- gone --), 2016/08/03 20:04:27]

This walkFileTree line isnt working on the WebRTC bot. It only ever visits the
file third_party/robolectric/ and nothing inside that. I have no idea why.

Anyway, this change is an improvement, because before the names of the input
template files and output files existed both in this file and in the BUILD.gn.
Now the BUILD.gn file just explicitly lists what the template files and output
files are through some arguments.

[jbudorick, 2016/08/03 22:24:03]

Java version?

[mikecase (-- gone --), 2016/08/03 22:29:55]

Maybe. Also, they mentioned they set up some symlinks in their build
0 lrwxrwxrwx 39 Aug  3 15:14 robolectric ->
../chromium/src/third_party/robolectric

Could also be a reason.

-                @Override
-                public FileVisitResult visitFile(
-                        Path path, BasicFileAttributes attrs) throws IOException {
-                    if (templatePathMatcher.matches(path)) {
-                        processTemplate(context, path, parser.getBaseTemplateDir(), parser.getOutputDir(), api);
-                    }
-                    return FileVisitResult.CONTINUE;
-                }
-            });
+            for(TemplateFileInfo templateFileInfo: parser.getTemplateFileInfoList()) {
+                processTemplate(context, templateFileInfo.getTemplateFile(),
+                        templateFileInfo.getOutputFile(), api);
+            }
         } catch (IOException e) {
             System.err.println("Error processing template files for Robolectric! " + e.toString());
         }
     }
 
-    private static void processTemplate(VelocityContext context, Path templateFile, Path baseTemplateDir, Path outputDir, int api_level) throws IOException {
+    private static void processTemplate(VelocityContext context, Path templateFile, Path outputFile, int api_level) throws IOException {

[jbudorick, 2016/08/03 22:24:03]

line length

[mikecase (-- gone --), 2016/08/03 22:29:55]

Done

         final StringWriter stringWriter = new StringWriter();
-        Template template = Velocity.getTemplate(baseTemplateDir.relativize(templateFile).toString(), "UTF-8");
+        Template template = Velocity.getTemplate(templateFile.toString(), "UTF-8");
         template.merge(context, stringWriter);
-
-        String templateFilename = templateFile.getFileName().toString();
-        String processedFilename = "" + api_level + File.separator + templateFilename.replace(".vm", "");
-
-        String relativeOutputFile = templateFile.toString().replace(baseTemplateDir.toString(), "").replace(templateFilename, processedFilename);
-
-        if (relativeOutputFile.startsWith("/")) {
-            relativeOutputFile = relativeOutputFile.substring(1);
-        }
-        Path outputFile = outputDir.resolve(relativeOutputFile);
         if (!Files.exists(outputFile.getParent())) {
             Files.createDirectories(outputFile.getParent());
         }
         Files.write(outputFile, stringWriter.toString().getBytes("UTF-8"));
     }
 }