Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2200373002: Unbreak ClangToTiOS more after gn switch (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, smut
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unbreak ClangToTiOS more after gn switch The bot used to set LLVM_FORCE_HEAD_REVISION during runhooks to make sure CR_CLANG_REVISION expanded to the latest version. In gn, this is done via a llvm_force_head_revision gn arg, but since the iOS bots don't use the normal machinery for build configs that needs to be specified twice there. BUG=633316 R=dpranke@chromium.org TBR=smut Committed: https://chromium.googlesource.com/chromium/src/+/c6ad2943220821b835486c5c3b6c6fe15aecf0d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/build/bots/chromium.fyi/ClangToTiOS.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
4 years, 4 months ago (2016-08-02 22:11:22 UTC) #6
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-02 22:11:35 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c6ad2943220821b835486c5c3b6c6fe15aecf0d2 Cr-Commit-Position: refs/heads/master@{#409346}
4 years, 4 months ago (2016-08-02 22:18:11 UTC) #9
Nico
4 years, 4 months ago (2016-08-02 22:19:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6ad2943220821b835486c5c3b6c6fe15aecf0d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698