Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2200333002: Remove flags for controlling credit card scanner. (Closed)

Created:
4 years, 4 months ago by please use gerrit instead
Modified:
4 years, 4 months ago
Reviewers:
Mathieu, Ilya Sherman
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, asvitkine+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flags for controlling credit card scanner. Credit card scanner is enabled for 100% of users on stable, so there's no need for flags and switches anymore. BUG=608388 Committed: https://crrev.com/44ff2e0856952be40d1fb99f9a6b91f343228187 Cr-Commit-Position: refs/heads/master@{#409415}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove autofill_switches.h include #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -5 lines 1 comment Download

Messages

Total messages: 25 (16 generated)
please use gerrit instead
Mathieu, ptal.
4 years, 4 months ago (2016-08-02 20:38:45 UTC) #4
Mathieu
lgtm with nit https://codereview.chromium.org/2200333002/diff/1/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (left): https://codereview.chromium.org/2200333002/diff/1/components/autofill/core/browser/autofill_manager.cc#oldcode260 components/autofill/core/browser/autofill_manager.cc:260: if (base::CommandLine::ForCurrentProcess()->HasSwitch( do you need to ...
4 years, 4 months ago (2016-08-02 20:45:34 UTC) #5
please use gerrit instead
https://codereview.chromium.org/2200333002/diff/1/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (left): https://codereview.chromium.org/2200333002/diff/1/components/autofill/core/browser/autofill_manager.cc#oldcode260 components/autofill/core/browser/autofill_manager.cc:260: if (base::CommandLine::ForCurrentProcess()->HasSwitch( On 2016/08/02 20:45:34, Mathieu Perreault wrote: > ...
4 years, 4 months ago (2016-08-02 22:52:21 UTC) #9
please use gerrit instead
Ilya, ptal testing/variations.
4 years, 4 months ago (2016-08-02 22:53:12 UTC) #13
Ilya Sherman
LGTM https://codereview.chromium.org/2200333002/diff/20001/testing/variations/fieldtrial_testing_config_android.json File testing/variations/fieldtrial_testing_config_android.json (left): https://codereview.chromium.org/2200333002/diff/20001/testing/variations/fieldtrial_testing_config_android.json#oldcode65 testing/variations/fieldtrial_testing_config_android.json:65: "CreditCardScan": [ Hmm, was the code to query ...
4 years, 4 months ago (2016-08-03 01:15:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200333002/20001
4 years, 4 months ago (2016-08-03 01:17:08 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 01:21:15 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/44ff2e0856952be40d1fb99f9a6b91f343228187 Cr-Commit-Position: refs/heads/master@{#409415}
4 years, 4 months ago (2016-08-03 01:24:09 UTC) #24
please use gerrit instead
4 years, 4 months ago (2016-08-03 16:42:47 UTC) #25
Message was sent while issue was closed.
On 2016/08/03 01:15:04, Ilya Sherman wrote:
>
https://codereview.chromium.org/2200333002/diff/20001/testing/variations/fiel...
> File testing/variations/fieldtrial_testing_config_android.json (left):
> 
>
https://codereview.chromium.org/2200333002/diff/20001/testing/variations/fiel...
> testing/variations/fieldtrial_testing_config_android.json:65:
"CreditCardScan":
> [
> Hmm, was the code to query this field trial state already removed in a
previous
> CL?

yes.

Powered by Google App Engine
This is Rietveld 408576698