Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3114)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm

Issue 2200303004: [Mac][Material Design] Adjust bookmark spacing and folder menu drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests, changes for icon-only items. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm
index c9e3c795554c881d7dcc580376031022cfb57ba5..31178191b460ea85eb73c792ce132c436ff485b2 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm
@@ -9,9 +9,17 @@
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h"
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h"
#import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSColor+Luminance.h"
+#include "ui/base/material_design/material_design_controller.h"
using bookmarks::kBookmarkBarMenuCornerRadius;
+namespace {
+
+// Material Design bookmark folder window background white.
+const CGFloat kMDFolderWindowBackgroundColor = 237. / 255.;
+
+} // namespace
+
@implementation BookmarkBarFolderWindow
- (id)initWithContentRect:(NSRect)contentRect
@@ -45,26 +53,39 @@ using bookmarks::kBookmarkBarMenuCornerRadius;
@implementation BookmarkBarFolderWindowContentView
++ (NSColor*)backgroundColor {
+ DCHECK(ui::MaterialDesignController::IsModeMaterial());
+ static NSColor* backgroundColor =
+ [[NSColor colorWithGenericGamma22White:kMDFolderWindowBackgroundColor
+ alpha:1.0] retain];
+ return backgroundColor;
+}
+
- (void)drawRect:(NSRect)rect {
// Like NSMenus, only the bottom corners are rounded.
NSBezierPath* bezier =
[NSBezierPath bezierPathWithRoundedRect:[self bounds]
xRadius:kBookmarkBarMenuCornerRadius
yRadius:kBookmarkBarMenuCornerRadius];
- NSColor* startColor = [NSColor colorWithCalibratedWhite:0.91 alpha:1.0];
- NSColor* midColor =
- [startColor gtm_colorAdjustedFor:GTMColorationLightMidtone faded:YES];
- NSColor* endColor =
- [startColor gtm_colorAdjustedFor:GTMColorationLightPenumbra faded:YES];
-
- base::scoped_nsobject<NSGradient> gradient(
- [[NSGradient alloc] initWithColorsAndLocations:startColor, 0.0,
- midColor, 0.25,
- endColor, 0.5,
- midColor, 0.75,
- startColor, 1.0,
- nil]);
- [gradient drawInBezierPath:bezier angle:0.0];
+ if (ui::MaterialDesignController::IsModeMaterial()) {
+ [[BookmarkBarFolderWindowContentView backgroundColor] set];
+ [bezier fill];
+ } else {
+ NSColor* startColor = [NSColor colorWithCalibratedWhite:0.91 alpha:1.0];
+ NSColor* midColor =
+ [startColor gtm_colorAdjustedFor:GTMColorationLightMidtone faded:YES];
+ NSColor* endColor =
+ [startColor gtm_colorAdjustedFor:GTMColorationLightPenumbra faded:YES];
+
+ base::scoped_nsobject<NSGradient> gradient(
+ [[NSGradient alloc] initWithColorsAndLocations:startColor, 0.0,
+ midColor, 0.25,
+ endColor, 0.5,
+ midColor, 0.75,
+ startColor, 1.0,
+ nil]);
+ [gradient drawInBezierPath:bezier angle:0.0];
+ }
}
@end
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698