Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6292)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 2200303004: [Mac][Material Design] Adjust bookmark spacing and folder menu drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests, changes for icon-only items. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
index f09e8fc25700e719361f215453e064db29c5137b..92e5da9dae080218c8b95aac23a6182c9dcb5488 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
@@ -269,14 +269,14 @@ CGFloat BookmarkLeftMargin() {
if (!ui::MaterialDesignController::IsModeMaterial()) {
return 2.0;
}
- return 10.0;
+ return 12.0;
}
CGFloat BookmarkRightMargin() {
if (!ui::MaterialDesignController::IsModeMaterial()) {
return 2.0;
}
- return 10.0;
+ return 12.0;
}
} // namespace bookmarks
@@ -1239,7 +1239,10 @@ CGFloat BookmarkRightMargin() {
// too small. For "FBL" it is 2 pixels too small.
// For a bookmark named "SFGateFooWoo", it is just fine.
- (CGFloat)widthForBookmarkButtonCell:(NSCell*)cell {
- CGFloat desired = [cell cellSize].width + 2;
+ CGFloat desired = [cell cellSize].width;
+ if (!ui::MaterialDesignController::IsModeMaterial()) {
+ desired += 2;
+ }
return std::min(desired, bookmarks::kDefaultBookmarkWidth);
}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698