[Mac][Material Design] Adjust bookmark spacing and folder menu drawing.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h"
 
 #include <stddef.h>
 
 #include "base/mac/bundle_locations.h"
 #include "base/mac/sdk_forward_declarations.h"
@@ skipping 314 matching lines @@
   //   [NSObject cancelPreviousPerformRequestsWithTarget:self];
   // Because all of our performSelector: calls use withDelay: which
   // retains us.
   [super dealloc];
 }
 
 - (void)awakeFromNib {
   NSRect windowFrame = [[self window] frame];
   NSRect scrollViewFrame = [scrollView_ frame];
   padding_ = NSWidth(windowFrame) - NSWidth(scrollViewFrame);
+  // In Material Design, each menu row spans the entire width of the menu.
+  if (ui::MaterialDesignController::IsModeMaterial()) {
+    scrollViewFrame.size.width += 2 * padding_;
+    scrollViewFrame.origin.x = 0;
+    [scrollView_ setFrame:scrollViewFrame];

[tapted, 2016/08/04 02:00:55]

I think has the unwanted side-effect of causing the menu NSWindows to lose their
rounded corners -- see http://i.imgur.com/os613QH.png - trimming the scroll view
from top and bottom (as well) may be able to fix it, but that will probably
affect some offsets elsewhere.

[shrike, 2016/08/04 20:54:47]

Thanks for catching that. This new patchset should address the issue.

+    padding_ = 0;
+  }
   verticalScrollArrowHeight_ = NSHeight([scrollUpArrowView_ frame]);
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   NSImage* image = rb.GetNativeImageNamed(IDR_MENU_OVERFLOW_DOWN).ToNSImage();
   [[scrollUpArrowView_.subviews objectAtIndex:0] setImage:image];
 
   image = rb.GetNativeImageNamed(IDR_MENU_OVERFLOW_UP).ToNSImage();
   [[scrollDownArrowView_.subviews objectAtIndex:0] setImage:image];
 }
 
@@ skipping 38 matching lines @@
                                             forADarkTheme:NO]
                          : nil;
   BookmarkContextMenuCocoaController* menuController =
       [barController_ menuController];
   BookmarkBarFolderButtonCell* cell =
       [BookmarkBarFolderButtonCell buttonCellForNode:child
                                                 text:nil
                                                image:image
                                       menuController:menuController];
   if (ui::MaterialDesignController::IsModeMaterial()) {
-    [cell setTag:kMaterialStandardButtonTypeWithLimitedClickFeedback];
+    [cell setTag:kMaterialMenuButtonTypeWithLimitedClickFeedback];
   } else {
     [cell setTag:kStandardButtonTypeWithLimitedClickFeedback];
   }
   return cell;
 }
 
 // Redirect to our logic shared with BookmarkBarController.
 - (IBAction)openBookmarkFolderFromButton:(id)sender {
   [folderTarget_ openBookmarkFolderFromButton:sender];
 }
@@ skipping 1685 matching lines @@
 
 - (void)setIgnoreAnimations:(BOOL)ignore {
   ignoreAnimations_ = ignore;
 }
 
 - (BookmarkButton*)buttonThatMouseIsIn {
   return buttonThatMouseIsIn_;
 }
 
 @end  // BookmarkBarFolderController