third_party/WebKit/Source/web/InspectorOverlay.cpp - Issue 2200303003: Remove v8CallOrCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/InspectorOverlay.cpp

diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp

index a616e259783efa5ab2d8eeaa5925ceab484503ce..e30b2572f5a5a89326ddc67829fb3dc32489cd8a 100644

--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp

+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp

@@ -513,7 +513,7 @@ Page* InspectorOverlay::overlayPage()

v8::Local<v8::Object> global = scriptState->context()->Global();

v8::Local<v8::Value> overlayHostObj = toV8(m_overlayHost.get(), global, isolate);

DCHECK(!overlayHostObj.IsEmpty());

- v8CallOrCrash(global->Set(scriptState->context(), v8AtomicString(isolate, "InspectorOverlayHost"), overlayHostObj));

+ global->Set(scriptState->context(), v8AtomicString(isolate, "InspectorOverlayHost"), overlayHostObj).ToChecked();

#if OS(WIN)

evaluateInOverlay("setPlatform", "windows");