Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2200263003: PPC/s390: Make FastNewFunctionContextStub take slots parameter (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Make FastNewFunctionContextStub take slots parameter Port 5bc243978396ab902f115e49aff2cf4bcb5d8a4c Original commit message: This will enable the interpreter to add a bytecode and use the stub. R=klaasb@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/bb2fd5d29d9cfc5f3413cd4a6fbc8e7f35b9b5d7 Cr-Commit-Position: refs/heads/master@{#38264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -44 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 4 months ago (2016-08-02 22:13:51 UTC) #1
john.yan
lgtm
4 years, 4 months ago (2016-08-02 22:34:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200263003/1
4 years, 4 months ago (2016-08-03 00:40:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 01:03:03 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 01:03:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb2fd5d29d9cfc5f3413cd4a6fbc8e7f35b9b5d7
Cr-Commit-Position: refs/heads/master@{#38264}

Powered by Google App Engine
This is Rietveld 408576698