Issue 220025: linux: port some of the download manager unit test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 220025: linux: port some of the download manager unit test (Closed)

Created:
11 years, 3 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Paul Godavari, Evan Stade, abarth-chromium

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: port some of the download manager unit test Mostly lots of #ifdefs tracking platform behaviors. I tried to make the logic correct for Mac, too, but I didn't enable Mac here. BUG=21632 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27260

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -28 lines)			Patch
	M	chrome/browser/download/download_manager_unittest.cc	View		13 chunks	+137 lines, -23 lines	0 comments	Download
	M	chrome/chrome.gyp	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

+abarth for security thoughts +estade fyi To answer Paul's question for abarth's benefit: this is ...

11 years, 3 months ago (2009-09-23 23:02:28 UTC) #2

abarth-chromium

This is all fine from a security point of view. I'll let others comment on ...

11 years, 3 months ago (2009-09-24 00:15:49 UTC) #3

LGTM (add BUG=21632)

Expand Messages | Collapse Messages