MD History: Refresh the list when clearing browsing data

chrome/browser/resources/md_history/list_container.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-list-container',
 
   properties: {
     // The path of the currently selected page.
     selectedPage_: String,
@@ skipping 26 matching lines @@
   historyResult: function(info, results) {
     this.initializeResults_(info, results);
     this.closeMenu_();
 
     if (this.selectedPage_ == 'grouped-list') {
       this.$$('#grouped-list').historyData = results;
       return;
     }
 
     var list = /** @type {HistoryListElement} */(this.$['infinite-list']);
-    list.addNewResults(results);
+    list.addNewResults(results, this.queryState.incremental,
+        this.getSelectedItemCount());

[tsergeant, 2016/08/17 06:58:28]

For simplicity, I would suggest only checking the selected item count before you
reload the list (in clearHistory below). If there are items selected, exit
without trying to reload.

That way, you don't need to store clearingHistory_ and it simplifies the logic a
lot. It's possible for the reload to go through when it shouldn't, but that case
would be very difficult to trigger. 

[lshang, 2016/08/18 08:41:54]

Done. Great idea!

     if (info.finished)
       list.disableResultLoading();
   },
 
   /**
    * Queries the history backend for results based on queryState.
    * @param {boolean} incremental Whether the new query should continue where
    *    the previous query stopped.
    */
   queryHistory: function(incremental) {
@@ skipping 22 matching lines @@
     }
 
     var maxResults =
       queryState.range == HistoryRange.ALL_TIME ? RESULTS_PER_PAGE : 0;
     chrome.send('queryHistory', [
       queryState.searchTerm, queryState.groupedOffset, queryState.range,
       lastVisitTime, maxResults
     ]);
   },
 
+  clearingHistory: function() {

[tsergeant, 2016/08/17 06:58:28]

For method names, use the plain verb form:

clearHistory()

For properties, you can still use the participle form:

this.clearingHistory_

to indicate that it's a continuous state.

[lshang, 2016/08/18 08:41:54]

Done.

+    /** @type {HistoryListElement} */ (this.$['infinite-list'])
+        .clearingHistory();
+  },
+
   /** @return {number} */
   getSelectedItemCount: function() {
     return this.getSelectedList_().selectedPaths.size;
   },
 
   unselectAllItems: function(count) {
     this.getSelectedList_().unselectAllItems(count);
   },
 
   /**
@@ skipping 107 matching lines @@
   },
 
   /**
    * @return {HTMLElement}
    * @private
    */
   getSelectedList_: function() {
     return this.$.content.selectedItem;
   },
 });