Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220023003: Rename LayoutBox to CSSBoxType (Closed)

Created:
6 years, 8 months ago by rwlbuis
Modified:
6 years, 8 months ago
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, Steve Block, rwlbuis, dino_apple.com, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, Timothy Loh, dstockwell, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink, Eric Willigers, rjwright, zoltan1, darktears, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename LayoutBox to CSSBoxType. Also rename the functions and methods that mention "LayoutBox" to something that makes sense for each specific situation. This is a merge of http://trac.webkit.org/changeset/165843 by Bem Jones-Bey <bjonesbe@adobe.com>;. BUG=358377 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/AnimatableShapeValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSBasicShapes.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSBasicShapes.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/shapes/BoxShapeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/Shape.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/Shape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeOutsideInfo.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/ShapeValue.h View 5 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Bem Jones-Bey (adobe)
I think this makes the code easier to read. But since I'm the author of ...
6 years, 8 months ago (2014-03-31 22:15:05 UTC) #1
Bem Jones-Bey (adobe)
Oh, one nit, you should make the name of the codereview something better, like "Rename ...
6 years, 8 months ago (2014-03-31 22:16:02 UTC) #2
rwlbuis
PTAL :)
6 years, 8 months ago (2014-03-31 22:17:24 UTC) #3
leviw_travelin_and_unemployed
This is much better. LGTM.
6 years, 8 months ago (2014-03-31 22:19:13 UTC) #4
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-03-31 22:20:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/220023003/1
6 years, 8 months ago (2014-03-31 22:20:33 UTC) #6
rwlbuis
The CQ bit was unchecked by rob.buis@samsung.com
6 years, 8 months ago (2014-03-31 22:25:20 UTC) #7
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 8 months ago (2014-03-31 22:25:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/220023003/1
6 years, 8 months ago (2014-03-31 22:25:56 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 00:16:41 UTC) #10
Message was sent while issue was closed. 
Change committed as 170496

Powered by Google App Engine
This is Rietveld 408576698