Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220023002: Cleanup ReferenceResolver (Closed)

Created:
6 years, 8 months ago by ahernandez
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup ReferenceResolver NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266714

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Add documentation in document_renderer.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -133 lines) Patch
M chrome/common/extensions/docs/server2/document_renderer.py View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/reference_resolver.py View 1 2 3 chunks +2 lines, -61 lines 0 comments Download
M chrome/common/extensions/docs/server2/reference_resolver_test.py View 1 1 chunk +0 lines, -71 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ahernandez
Could you please review these changes? Thank you.
6 years, 8 months ago (2014-03-31 21:23:06 UTC) #1
not at google - send to devlin
Freddy, it's good for you to have some other people review your code too, so ...
6 years, 8 months ago (2014-03-31 21:39:04 UTC) #2
ahernandez
Friendly ping, PTAL.
6 years, 8 months ago (2014-04-08 18:07:02 UTC) #3
not at google - send to devlin
lgtm. no poing having an empty BUG= though. https://codereview.chromium.org/220023002/diff/40001/chrome/common/extensions/docs/server2/reference_resolver.py File chrome/common/extensions/docs/server2/reference_resolver.py (right): https://codereview.chromium.org/220023002/diff/40001/chrome/common/extensions/docs/server2/reference_resolver.py#newcode59 chrome/common/extensions/docs/server2/reference_resolver.py:59: for ...
6 years, 8 months ago (2014-04-09 14:32:58 UTC) #4
not at google - send to devlin
.. point.
6 years, 8 months ago (2014-04-09 14:33:03 UTC) #5
ahernandez
ping jyasskin@, could you please take a quick look at these cleanup changes?
6 years, 8 months ago (2014-04-22 00:44:52 UTC) #6
Jeffrey Yasskin
https://codereview.chromium.org/220023002/diff/40001/chrome/common/extensions/docs/server2/reference_resolver.py File chrome/common/extensions/docs/server2/reference_resolver.py (right): https://codereview.chromium.org/220023002/diff/40001/chrome/common/extensions/docs/server2/reference_resolver.py#newcode50 chrome/common/extensions/docs/server2/reference_resolver.py:50: correct node. See document_renderer.py for more information on $ref ...
6 years, 8 months ago (2014-04-24 18:38:18 UTC) #7
ahernandez
Added documentation, PTAL
6 years, 7 months ago (2014-04-28 22:52:28 UTC) #8
Jeffrey Yasskin
lgtm
6 years, 7 months ago (2014-04-28 23:20:23 UTC) #9
ahernandez
The CQ bit was checked by ahernandez.miralles@gmail.com
6 years, 7 months ago (2014-04-28 23:21:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahernandez.miralles@gmail.com/220023002/60001
6 years, 7 months ago (2014-04-28 23:22:06 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 00:16:05 UTC) #12
Message was sent while issue was closed. 
Change committed as 266714

Powered by Google App Engine
This is Rietveld 408576698