A refactor broke the find bar...characters like ! and ( ...

A refactor broke the find bar...characters like ! and ( 
became unsearchable

BUG=10509
TEST=Open nytimes.com, search for "new". Then type "!". It should appear in the search box but not be found (unless the the text "new!" is really in the page. Confirm you can search for ( and & as well.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27012

[Finnur, 2009-09-23 21:49:28]

Your changelist should have a TEST=

Apart from that, just nits.

http://codereview.chromium.org/220019/diff/3001/4002
File chrome/browser/views/find_bar_host.cc (right):

http://codereview.chromium.org/220019/diff/3001/4002#newcode359
Line 359: // Native implementation says to eat these events
Eat is not the right word here, since we are actually not eating them. We are
not acting on them and letting the textfield handle it.

nit: Missing period at end.

http://codereview.chromium.org/220019/diff/3001/4004
File chrome/browser/views/find_bar_host.h (right):

http://codereview.chromium.org/220019/diff/3001/4004#newcode50
Line 50: public FindBarTesting {
nit: Can you fix the indentation here too?

http://codereview.chromium.org/220019/diff/3001/4004#newcode160
Line 160: const views::Textfield::Keystroke& key_stroke);
nit: 4 columns, not 2

http://codereview.chromium.org/220019/diff/3001/4003
File chrome/browser/views/find_bar_host_win.cc (right):

http://codereview.chromium.org/220019/diff/3001/4003#newcode193
Line 193: const views::Textfield::Keystroke& key_stroke) {
Indentation (4).

[DaveMoore, 2009-09-23 22:17:48]

http://codereview.chromium.org/220019/diff/3001/4002
File chrome/browser/views/find_bar_host.cc (right):

http://codereview.chromium.org/220019/diff/3001/4002#newcode359
Line 359: // Native implementation says to eat these events
On 2009/09/23 21:49:28, Finnur wrote:
> Eat is not the right word here, since we are actually not eating them. We are
> not acting on them and letting the textfield handle it.
> 
> nit: Missing period at end.

Done.

http://codereview.chromium.org/220019/diff/3001/4004
File chrome/browser/views/find_bar_host.h (right):

http://codereview.chromium.org/220019/diff/3001/4004#newcode50
Line 50: public FindBarTesting {
On 2009/09/23 21:49:28, Finnur wrote:
> nit: Can you fix the indentation here too?

Done.

http://codereview.chromium.org/220019/diff/3001/4004#newcode160
Line 160: const views::Textfield::Keystroke& key_stroke);
On 2009/09/23 21:49:28, Finnur wrote:
> nit: 4 columns, not 2

Done.

http://codereview.chromium.org/220019/diff/3001/4003
File chrome/browser/views/find_bar_host_win.cc (right):

http://codereview.chromium.org/220019/diff/3001/4003#newcode193
Line 193: const views::Textfield::Keystroke& key_stroke) {
On 2009/09/23 21:49:28, Finnur wrote:
> Indentation (4).

Done.

[Finnur, 2009-09-23 22:21:40]

nit: You have an unbalanced parenthesis in your TEST= line. No biggie. :)

LGTM

http://codereview.chromium.org/220019/diff/9001/11
File chrome/browser/views/find_bar_host.cc (right):

http://codereview.chromium.org/220019/diff/9001/11#newcode359
Line 359: // Native implementation not to forward these events.
nit: not -> says not ?